linux-kernel - Re: [PATCH v8 10/32] x86,fs/resctrl: Rename struct rdt_mon_domain and rdt_hw_mon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87f8af1e-24de-4f1e-814a-2904dc1d2e56@intel.com>
Date: Wed, 13 Aug 2025 21:09:11 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>, Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v8 10/32] x86,fs/resctrl: Rename struct rdt_mon_domain and
 rdt_hw_mon_domain

Hi Tony,

On 8/11/25 11:16 AM, Tony Luck wrote:
> All monitoring events are associated with the L3 resource.

With a bit more context:
	All monitoring events are associated with the L3 resource.
	The per L3 domain resctrl fs monitoring state is maintained in the
	generically named struct rdt_mon_domain while the per L3 domain
	architecture specific monitoring state is maintained                       
	in the generically named struct rdt_hw_mon_domain.

> 
> This will change when support for telemetry events is added.

	Upcoming telemetry event monitoring will be tied to another resource
	and requires new domain structures. 

> 
> The structures to track monitor domains of the L3 resource at both the
> file system and architecture level have generic names. This may cause
> confusion when support for monitoring events in other resources is added.

	Rename the L3 resource specific domain data structures to include
	"l3_" in their names to avoid confusion between the different
	resource specific domain structures:
	rdt_mon_domain		-> rdt_l3_mon_domain
	rdt_hw_mon_domain	-> rdt_hw_l3_mon_domain
> 
> Rename by adding "l3_" into the names:
> rdt_mon_domain		-> rdt_l3_mon_domain
> rdt_hw_mon_domain	-> rdt_hw_l3_mon_domain
> 
> No functional change.
> 
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> ---

Running "git grep rdt_mon_domain" with this series applied found one more spot
that needs to switch:
arch/x86/kernel/cpu/resctrl/monitor.c: * nodes that share an L3 cache). Linux creates an rdt_mon_domain for

Reinette