linux-kernel - Re: [PATCH v2 1/3] media: dt-bindings: qcom,sm8550-iris: Add SM8750 video codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04b34250-520e-6320-bfcf-4dbb4ea0c523@quicinc.com>
Date: Thu, 14 Aug 2025 09:56:10 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Krzysztof Kozlowski
	<krzk@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Vikash Garodia <quic_vgarodia@...cinc.com>,
        Abhinav Kumar
	<abhinav.kumar@...ux.dev>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "Rob
 Herring" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Conor
 Dooley" <conor+dt@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
CC: <linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] media: dt-bindings: qcom,sm8550-iris: Add SM8750
 video codec



On 8/14/2025 2:45 AM, Bryan O'Donoghue wrote:
> On 12/08/2025 09:04, Krzysztof Kozlowski wrote:
>> On 12/08/2025 10:00, Krzysztof Kozlowski wrote:
>>> On 12/08/2025 09:54, Dikshita Agarwal wrote:
>>>>
>>>>
>>>> On 8/4/2025 7:07 PM, Krzysztof Kozlowski wrote:
>>>>> Add binding for Qualcom SM8750 Iris video codec, which comes with
>>>>> significantly different powering up sequence than previous SM8650, thus
>>>>> different clocks and resets.  For consistency keep existing clock and
>>>>> clock-names naming, so the list shares common part.
>>>>>
>>>>> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>>> ---
>>>>>   .../bindings/media/qcom,sm8750-iris.yaml           | 186
>>>>> +++++++++++++++++++++
>>>>>   1 file changed, 186 insertions(+)
>>>>>
>>>>
>>>> Query:
>>>> Can the additional reset and clocks be accommodated in existing 8550-iris
>>>
>>> No, different hardware. Although it is hardware from your domain and
>>> your company, so I would assume you know the answer.
>> I guess I misread - I thought you want to re-use existing properties or
>> something like that, but you just want to create one huge binding?
>>
>> No. Don't grow these unmaintainable patterns. We have been changing this
>> for some time already :/
>>
>> Best regards,
>> Krzysztof
> 
> @Dikshita can you revert here are you happy with a new binding or
> requesting in-line changes in Iris - my reading here is a binding is
> justified.
> 

Sure, but I was trying to understand how extending the current SM8550
binding for [1] wasn't an issue.

[1]
https://lore.kernel.org/linux-media/20250417-topic-sm8x50-iris-v10-v7-1-f020cb1d0e98@linaro.org/

Thanks,
Dikshita

> @Krzysztof
> https://lore.kernel.org/linux-arm-msm/fb8f154b-3da4-4bee-82e1-3a1597a35c46@kernel.org/
> 
> Are you sending a v3 here ?
> 
> I can also just add the OPP when applying this patch.
> 
> ---
> bod
>