linux-kernel - Re: [PATCH v3 3/4] misc: fastrpc: fix possible map leak in fastrpc_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7gen36c5as6fxpgeinc6if7ysex4ieswh2uhqqjtqlt37tj7or@ngpiqfyg2p56>
Date: Thu, 14 Aug 2025 10:02:08 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Ling Xu <quic_lxu5@...cinc.com>
Cc: srini@...nel.org, amahesh@....qualcomm.com, arnd@...db.de,
        gregkh@...uxfoundation.org, sumit.semwal@...aro.org,
        christian.koenig@....com, thierry.escande@...aro.org,
        quic_vgattupa@...cinc.com, quic_kuiw@...cinc.com,
        ekansh.gupta@....qualcomm.com, dri-devel@...ts.freedesktop.org,
        linux-arm-msm@...r.kernel.org, linux-media@...r.kernel.org,
        linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org,
        stable@...nel.org
Subject: Re: [PATCH v3 3/4] misc: fastrpc: fix possible map leak in
 fastrpc_put_args

On Thu, Aug 07, 2025 at 03:34:19PM +0530, Ling Xu wrote:
> copy_to_user() failure would cause an early return without cleaning up
> the fdlist, which has been updated by the DSP. This could lead to map
> leak. Fix this by redirecting to a cleanup path on failure, ensuring
> that all mapped buffers are properly released before returning.
> 
> Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context Invoke method")
> Cc: stable@...nel.org
> Co-developed-by: Ekansh Gupta <ekansh.gupta@....qualcomm.com>
> Signed-off-by: Ekansh Gupta <ekansh.gupta@....qualcomm.com>
> Signed-off-by: Ling Xu <quic_lxu5@...cinc.com>
> ---
>  drivers/misc/fastrpc.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>


-- 
With best wishes
Dmitry