linux-kernel - Re: [PATCH v4 4/7] ALSA: usb-audio: us144mkii: Implement audio capture and decoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ms82uye9.wl-tiwai@suse.de>
Date: Thu, 14 Aug 2025 09:59:26 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Šerif Rami <ramiserifpersia@...il.com>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	linux-kernel@...r.kernel.org,
	linux-sound@...r.kernel.org
Subject: Re: [PATCH v4 4/7] ALSA: usb-audio: us144mkii: Implement audio capture and decoding

On Wed, 13 Aug 2025 15:15:15 +0200,
Šerif Rami wrote:
> 
> +void tascam_capture_work_handler(struct work_struct *work)
> +{
....
> +	while (atomic_read(&tascam->capture_active)) {
> +		size_t write_ptr, read_ptr, available_data;
> +		bool can_process;
> +
> +		{
> +			guard(spinlock_irqsave)(&tascam->lock);

Use scoped_guard().

> +		decode_tascam_capture_block(raw_block, decoded_block);
> +		process_capture_routing_us144mkii(tascam, decoded_block,
> +						  routed_block);
> +
> +		{
> +			guard(spinlock_irqsave)(&tascam->lock);

Ditto.


> +void capture_urb_complete(struct urb *urb)
> +{
....
> +	if (urb->actual_length > 0) {
> +		size_t write_ptr;
> +		size_t bytes_to_end;
> +
> +		{
> +			guard(spinlock_irqsave)(&tascam->lock);

Ditto.


thanks,

Takashi