linux-kernel - Re: [PATCH 4/7] rust: fs: update ARef and AlwaysRefCounted imports from sync::aref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJ2aUwi1L5RjK-X_@google.com>
Date: Thu, 14 Aug 2025 08:12:03 +0000
From: Alice Ryhl <aliceryhl@...gle.com>
To: Shankari Anand <shankari.ak0208@...il.com>, Christian Brauner <brauner@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	"Björn Roy Baron" <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>
Subject: Re: [PATCH 4/7] rust: fs: update ARef and AlwaysRefCounted imports
 from sync::aref

On Thu, Aug 14, 2025 at 12:56:21AM +0530, Shankari Anand wrote:
> On Wed, Jul 16, 2025 at 02:48:27PM +0530, Shankari Anand wrote:
> > Update call sites in the fs subsystem to import `ARef` and
> > `AlwaysRefCounted` from `sync::aref` instead of `types`.
> > 
> > This aligns with the ongoing effort to move `ARef` and
> > `AlwaysRefCounted` to sync.
> > 
> > Suggested-by: Benno Lossin <lossin@...nel.org>
> > Link: https://github.com/Rust-for-Linux/linux/issues/1173
> > Signed-off-by: Shankari Anand <shankari.ak0208@...il.com>
> > ---
> > It part of a subsystem-wise split series, as suggested in:
> > https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@mail.gmail.com/T/#u
> > This split series is intended to ease review and subsystem-level maintenance.
> > 
> > The original moving patch is here:
> > https://lore.kernel.org/rust-for-linux/20250625111133.698481-1-shankari.ak0208@gmail.com/
> > 
> > Gradually the re-export from types.rs will be eliminated in the
> > future cycle.
> > ---
> >  rust/kernel/fs/file.rs | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/rust/kernel/fs/file.rs b/rust/kernel/fs/file.rs
> > index 35fd5db35c46..18cf579d3312 100644
> > --- a/rust/kernel/fs/file.rs
> > +++ b/rust/kernel/fs/file.rs
> > @@ -11,7 +11,8 @@
> >      bindings,
> >      cred::Credential,
> >      error::{code::*, Error, Result},
> > -    types::{ARef, AlwaysRefCounted, NotThreadSafe, Opaque},
> > +    sync::aref::{ARef, AlwaysRefCounted},
> > +    types::{NotThreadSafe, Opaque},
> >  };
> >  use core::ptr;
> >  
> > -- 
> > 2.34.1
> > 
> 
> Hello, can this be picked for review?
> 
> The initial patch which moves ARef and AlwaysRefCounted to sync/aref.rs is upstream (commit 07dad44aa9a93) [1]
> 
> Thanks,
> Shankari
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440

Christian maintains rust/kernel/fs, so could you resend this patch with

	Christian Brauner <brauner@...nel.org>

as a recipient?

Feel free to add this when you resend:
Acked-by: Alice Ryhl <aliceryhl@...gle.com>