[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e6e06ab1-6744-4730-a2a7-be8c66bf74a3@kernel.org>
Date: Thu, 14 Aug 2025 10:41:57 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: leqi@....qualcomm.com, Konrad Dybcio <konradybcio@...nel.org>,
Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for
Hamoa-IOT-EVK
On 28/07/2025 13:08, Krzysztof Kozlowski wrote:
> On 28/07/2025 09:16, leqi via B4 Relay wrote:
>> From: leqi <leqi@....qualcomm.com>
>>
>> This patch adds initial audio codec support for the Hamoa-IOT-EVK board,
>> including WCD9385 configuration, micbias voltage settings, GPIO reset,
>> and power supply bindings. It enables basic audio functionality for
>> further development. Basic test is good in Hamoa-IOT-EVK board.
>>
>> Signed-off-by: leqi <leqi@....qualcomm.com>
>> ---
>> Changes in v2:
>> - Updated author email address to leqi@....qualcomm.com.
>> - Clarified that audio is validated with this change.
>> - Link to v1: https://lore.kernel.org/all/20250723-initial_audio_support_for_qualcomm_hamoa_iot_evk_board-v1-1-816991701952@quicinc.com/
>> ---
>> arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 232 +++++++++++++++++++++++++++++
>> 1 file changed, 232 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>> index 843f39c9d59286a9303a545411b2518d7649a059..91618e22e86c46c698b3639f60bc19314705b391 100644
>> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>> @@ -124,6 +124,94 @@ pmic_glink_ss2_con_sbu_in: endpoint {
>
>
> This was not merged, was it? Same comment as other patch, when you have
> entire code ready send entire board. Not chunk by chunk.
>
> You are not following properly release early, release often.
Why this is still not included in initial submission which happens now?
Either you work Linux style (release early) or, if you decide to wait
till everything is ready, you submit board as one patch, not everything
as 100 different patches.
Best regards,
Krzysztof
Powered by blists - more mailing lists