linux-kernel - Re: [PATCH v2 1/3] dt-bindings: input: Add bindings for Awinic AW86927

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250814-towering-rough-raptor-f4dc2d@kuoka>
Date: Thu, 14 Aug 2025 10:58:15 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Griffin Kroah-Hartman <griffin.kroah@...rphone.com>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Luca Weiss <luca.weiss@...rphone.com>, 
	linux-input@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: input: Add bindings for Awinic
 AW86927

On Mon, Aug 11, 2025 at 01:12:01PM +0200, Griffin Kroah-Hartman wrote:
> Add bindings for the Awinic AW86927 haptic chip which can be found in
> smartphones.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

If you are going to send new version, then also:

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Best regards,
Krzysztof