[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <e8d33a38-6465-432a-9c28-25f2689e95da@gmail.com>
Date: Thu, 14 Aug 2025 10:42:47 +0100
From: Pavel Begunkov <asml.silence@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Byungchul Park <byungchul@...com>, akpm@...ux-foundation.org,
linux-kernel@...r.kernel.org, kernel_team@...ynix.com, harry.yoo@...cle.com,
ast@...nel.org, daniel@...earbox.net, davem@...emloft.net, hawk@...nel.org,
john.fastabend@...il.com, sdf@...ichev.me, saeedm@...dia.com,
leon@...nel.org, tariqt@...dia.com, mbloch@...dia.com,
andrew+netdev@...n.ch, edumazet@...gle.com, pabeni@...hat.com,
david@...hat.com, lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com,
vbabka@...e.cz, rppt@...nel.org, surenb@...gle.com, mhocko@...e.com,
horms@...nel.org, jackmanb@...gle.com, hannes@...xchg.org, ziy@...dia.com,
ilias.apalodimas@...aro.org, willy@...radead.org, brauner@...nel.org,
kas@...nel.org, yuzhao@...gle.com, usamaarif642@...il.com,
baolin.wang@...ux.alibaba.com, almasrymina@...gle.com, toke@...hat.com,
bpf@...r.kernel.org, linux-rdma@...r.kernel.org, sfr@...b.auug.org.au,
linux-mm@...ck.org, netdev@...r.kernel.org
Subject: Re: [PATCH linux-next v3] mm, page_pool: introduce a new page type
for page pool in page type
On 8/13/25 15:52, Jakub Kicinski wrote:
> On Wed, 13 Aug 2025 12:18:56 +0100 Pavel Begunkov wrote:
>> It should go to net, there will be enough of conflicts otherwise.
>> mm maintainers, do you like it as a shared branch or can it just
>> go through the net tree?
>
> Looks like this is 100% in mm, and the work is not urgent at all.
There is a slight dependency in rc1, but we should be able to
massage it to be mm only.
> So I'm happy for Andrew to take this, and dependent patches (if any)
> can come in the next cycle.
Yeah, good option. It'd be a good idea to cut the diff down to
avoid removing the relevant mm page state checks until the next
cycle.
>> @@ -1379,9 +1376,11 @@ __always_inline bool free_pages_prepare(struct page *page,
>> mod_mthp_stat(order, MTHP_STAT_NR_ANON, -1);
>> folio->mapping = NULL;
>> }
>> - if (unlikely(page_has_type(page)))
>> + if (unlikely(page_has_type(page))) {
>> + WARN_ON_ONCE(PageNet_pp(page));
>
> I guess my ask to add a comment here got ignored?
It's an old patch attached as a point of reference. Any actual submission
surely will need to follow up on the reviews.
--
Pavel Begunkov
Powered by blists - more mailing lists