linux-kernel - Re: [PATCH] riscv: sbi: Switch to new sys-off handler API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b2a4df29-f35c-403a-a2a1-47ca9fce0023@ghiti.fr>
Date: Thu, 14 Aug 2025 11:20:21 +0200
From: Alexandre Ghiti <alex@...ti.fr>
To: Andrew Davis <afd@...com>, Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>
Cc: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: sbi: Switch to new sys-off handler API

Hi Andrew,

On 8/13/25 17:18, Andrew Davis wrote:
> Kernel now supports chained power-off handlers. Use
> register_platform_power_off() that registers a platform level power-off
> handler. Legacy pm_power_off() will be removed once all drivers and archs
> are converted to the new sys-off API.
>
> Signed-off-by: Andrew Davis <afd@...com>
> ---
>   arch/riscv/kernel/sbi.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kernel/sbi.c b/arch/riscv/kernel/sbi.c
> index 53836a9235e32..5e8cde0552643 100644
> --- a/arch/riscv/kernel/sbi.c
> +++ b/arch/riscv/kernel/sbi.c
> @@ -148,7 +148,7 @@ static int __sbi_rfence_v01(int fid, const struct cpumask *cpu_mask,
>   
>   static void sbi_set_power_off(void)
>   {
> -	pm_power_off = sbi_shutdown;
> +	register_platform_power_off(sbi_shutdown);
>   }
>   #else
>   static void __sbi_set_timer_v01(uint64_t stime_value)
> @@ -682,7 +682,7 @@ void __init sbi_init(void)
>   		if (sbi_spec_version >= sbi_mk_version(0, 3) &&
>   		    sbi_probe_extension(SBI_EXT_SRST)) {
>   			pr_info("SBI SRST extension detected\n");
> -			pm_power_off = sbi_srst_power_off;
> +			register_platform_power_off(sbi_srst_power_off);
>   			sbi_srst_reboot_nb.notifier_call = sbi_srst_reboot;
>   			sbi_srst_reboot_nb.priority = 192;
>   			register_restart_handler(&sbi_srst_reboot_nb);


Tested-by: Alexandre Ghiti <alexghiti@...osinc.com>
Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>

I'll take that for 6.18.

Thanks,

Alex