linux-kernel - RE: [PATCH v7 03/13] PCI: cadence: Add register definitions for HPA(High Perf Architecture)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CH2PPF4D26F8E1C1DDDAB9E861818FD3A32A235A@CH2PPF4D26F8E1C.namprd07.prod.outlook.com>
Date: Thu, 14 Aug 2025 01:29:39 +0000
From: Manikandan Karunakaran Pillai <mpillai@...ence.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        "hans.zhang@...tech.com"
	<hans.zhang@...tech.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
        "kw@...ux.com"
	<kw@...ux.com>, "mani@...nel.org" <mani@...nel.org>,
        "robh@...nel.org"
	<robh@...nel.org>,
        "kwilczynski@...nel.org" <kwilczynski@...nel.org>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "conor+dt@...nel.org"
	<conor+dt@...nel.org>
CC: "fugang.duan@...tech.com" <fugang.duan@...tech.com>,
        "guoyin.chen@...tech.com" <guoyin.chen@...tech.com>,
        "peter.chen@...tech.com"
	<peter.chen@...tech.com>,
        "cix-kernel-upstream@...tech.com"
	<cix-kernel-upstream@...tech.com>,
        "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v7 03/13] PCI: cadence: Add register definitions for
 HPA(High Perf Architecture)



>On 13/08/2025 06:23, hans.zhang@...tech.com wrote:
>>  static inline u32 cdns_pcie_read_sz(void __iomem *addr, int size)
>>  {
>>  	void __iomem *aligned_addr = PTR_ALIGN_DOWN(addr, 0x4);
>> @@ -313,19 +410,17 @@ static inline void cdns_pcie_ep_disable(struct
>cdns_pcie_ep *ep)
>>  #endif
>>
>>  void cdns_pcie_detect_quiet_min_delay_set(struct cdns_pcie *pcie);
>> -
>>  void cdns_pcie_set_outbound_region(struct cdns_pcie *pcie, u8 busnr, u8
>fn,
>>  				   u32 r, bool is_io,
>>  				   u64 cpu_addr, u64 pci_addr, size_t size);
>> -
>>  void cdns_pcie_set_outbound_region_for_normal_msg(struct cdns_pcie
>*pcie,
>>  						  u8 busnr, u8 fn,
>>  						  u32 r, u64 cpu_addr);
>> -
>>  void cdns_pcie_reset_outbound_region(struct cdns_pcie *pcie, u32 r);
>>  void cdns_pcie_disable_phy(struct cdns_pcie *pcie);
>> -int cdns_pcie_enable_phy(struct cdns_pcie *pcie);
>> -int cdns_pcie_init_phy(struct device *dev, struct cdns_pcie *pcie);
>> +int  cdns_pcie_enable_phy(struct cdns_pcie *pcie);
>> +int  cdns_pcie_init_phy(struct device *dev, struct cdns_pcie *pcie);
>
>I don't understand how this (and many other pieces here) is related to
>"add register definitions".
>
>This is not a register definition.
>
>

This is just an indentation change to make it aligned with the other functions definitions. However, for the other changes that
you are mentioning which are not register definitions, there was some movement of code when new files were created wherein function definitions/structure definitions/enums were relocated. I will update the description to reflect these.
>
>Best regards,
>Krzysztof