linux-kernel - RE: [PATCH v3 net-next 03/15] dt-bindings: net: add an example for ENETC v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB85100738E2AD741CA5C8E9648835A@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Thu, 14 Aug 2025 01:34:32 +0000
From: Wei Fang <wei.fang@....com>
To: Frank Li <frank.li@....com>
CC: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"richardcochran@...il.com" <richardcochran@...il.com>, Claudiu Manoil
	<claudiu.manoil@....com>, Vladimir Oltean <vladimir.oltean@....com>, Clark
 Wang <xiaoning.wang@....com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"vadim.fedorenko@...ux.dev" <vadim.fedorenko@...ux.dev>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>, "F.S.
 Peng" <fushi.peng@....com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: RE: [PATCH v3 net-next 03/15] dt-bindings: net: add an example for
 ENETC v4

> On Wed, Aug 13, 2025 at 01:38:55AM +0000, Wei Fang wrote:
> > > On Tue, Aug 12, 2025 at 05:46:22PM +0800, Wei Fang wrote:
> > > > Add a DT node example for ENETC v4 device.
> > >
> > > Not sure why need add examples here? Any big difference with existed
> > > example?
> > >
> >
> > For enetc v4, we have added clocks, and it also supports ptp-timer
> > property, these are different from enetc v1, so I think it is better to
> > add an example for v4.
> 
> If there are not big change, needn't duplicate one example at yaml file,
> the content should be in dts file already. Pass DTB_CHECK should be okay.
>

Okay, I can remove this patch in next version

 
> >
> > >
> > > >
> > > > Signed-off-by: Wei Fang <wei.fang@....com>
> > > >
> > > > ---
> > > > v2 changes:
> > > > new patch
> > > > v3 changes:
> > > > 1. Rename the subject
> > > > 2. Remove nxp,netc-timer property and use ptp-timer in the example
> > > > ---
> > > >  .../devicetree/bindings/net/fsl,enetc.yaml        | 15
> +++++++++++++++
> > > >  1 file changed, 15 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > > b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > > index ca70f0050171..a545b54c9e5d 100644
> > > > --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > > +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > > @@ -86,3 +86,18 @@ examples:
> > > >              };
> > > >          };
> > > >      };
> > > > +  - |
> > > > +    pcie {
> > > > +      #address-cells = <3>;
> > > > +      #size-cells = <2>;
> > > > +
> > > > +      ethernet@0,0 {
> > > > +          compatible = "pci1131,e101";
> > > > +          reg = <0x000000 0 0 0 0>;
> > > > +          clocks = <&scmi_clk 102>;
> > > > +          clock-names = "ref";
> > > > +          phy-handle = <&ethphy0>;
> > > > +          phy-mode = "rgmii-id";
> > > > +          ptp-timer = <&netc_timer>;
> > > > +      };
> > > > +    };
> > > > --
> > > > 2.34.1
> > > >