linux-kernel - Re: [PATCH v3 0/2] Add the s32g2 and s32g3 FTM PWM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jmhzng2ezrrqhy52y7eru2ik6uburn4rnilfwreqmvkeirqbnm@b5ksjlufwuwf>
Date: Thu, 14 Aug 2025 12:54:00 +0200
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	Frank.Li@....com, linux-pwm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Ghennadi.Procopciuc@....com, s32@....com
Subject: Re: [PATCH v3 0/2] Add the s32g2 and s32g3 FTM PWM support

Hello Daniel,

On Tue, Aug 12, 2025 at 10:00:34PM +0200, Daniel Lezcano wrote:
> The NXP Automotive platform s32g2 and s32g3 have on their board a
> FlexTimer (FTM) dedicated for the PWM. The same IP is found on the
> Freescale Vybrid Family and the i.MX8 SoCs. However, there is a small
> difference with some registers not available on the s32g2/3 and 6
> channels instead of 8.
> 
> These two patches provide the DT bindings for the s32g2/3 compatible
> strings and the code to deal with the FTM difference.
> 
> Changelog:
>         v3:
> 	 - Fixed dt-bindings subject prefix
>         v2:
> 	 - Merged the two booleans for the regmap holes check
> 	 - Clarified why this is needed in the changelog
> 	v1:
> 	 - Initial post
> 
> Daniel Lezcano (1):
>   dt-bindings: pwm: fsl,vf610-ftm-pwm: Add compatible for s32g2 and
>     s32g3
> 
> Ghennadi Procopciuc (1):
>   pwm: Add the S32G support in the Freescale FTM driver

Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

with this merge conflict resolution:

diff --cc drivers/pwm/pwm-fsl-ftm.c
index 6683931872fc,e0069dbdb02d..000000000000
--- a/drivers/pwm/pwm-fsl-ftm.c
+++ b/drivers/pwm/pwm-fsl-ftm.c
@@@ -396,7 -428,9 +416,7 @@@ static int fsl_pwm_probe(struct platfor
  		return PTR_ERR(chip);
  	fpc = to_fsl_chip(chip);
  
 -	mutex_init(&fpc->lock);
 -
- 	fpc->soc = of_device_get_match_data(&pdev->dev);
+ 	fpc->soc = soc;
  
  	base = devm_platform_ioremap_resource(pdev, 0);
  	if (IS_ERR(base))

The pro tip here to make your upstream maintainer lucky is to work on
their tree or next or at least the latest development release and make
use of `git format-patch --base`.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)