linux-kernel - Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <71ad3354-15ab-48b4-9e13-ea497d4fdd79@kernel.org>
Date: Thu, 14 Aug 2025 13:17:49 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Quill Qi <leqi@....qualcomm.com>, Konrad Dybcio <konradybcio@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for
 Hamoa-IOT-EVK

On 14/08/2025 11:48, Quill Qi wrote:
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Thursday, August 14, 2025 4:41 PM
> To: Quill Qi <leqi@....qualcomm.com>; Konrad Dybcio <konradybcio@...nel.org>; Bjorn Andersson <andersson@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>
> Cc: linux-arm-msm@...r.kernel.org <linux-arm-msm@...r.kernel.org>; devicetree@...r.kernel.org <devicetree@...r.kernel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>
> Subject: Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK
> 
> 
>> On 28/07/2025 13:08, Krzysztof Kozlowski wrote:
>>> On 28/07/2025 09:16, leqi via B4 Relay wrote:
>>>> From: leqi <leqi@....qualcomm.com>
>>>>
>>>> This patch adds initial audio codec support for the Hamoa-IOT-EVK board,
>>>> including WCD9385 configuration, micbias voltage settings, GPIO reset,
>>>> and power supply bindings. It enables basic audio functionality for
>>>> further development. Basic test is good in Hamoa-IOT-EVK board.
>>>>
>>>> Signed-off-by: leqi <leqi@....qualcomm.com>
>>>> ---
>>>> Changes in v2:
>>>> - Updated author email address to leqi@....qualcomm.com.
>>>> - Clarified that audio is validated with this change.
>>>> - Link to v1: https://lore.kernel.org/all/20250723-initial_audio_support_for_qualcomm_hamoa_iot_evk_board-v1-1-816991701952@quicinc.com/
>>>> ---
>>>> arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 232 +++++++++++++++++++++++++++++
>>>> 1 file changed, 232 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>>>> index 843f39c9d59286a9303a545411b2518d7649a059..91618e22e86c46c698b3639f60bc19314705b391 100644
>>>> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>>>> @@ -124,6 +124,94 @@ pmic_glink_ss2_con_sbu_in: endpoint {
>>>
>>>
>>> This was not merged, was it? Same comment as other patch, when you have
>>> entire code ready send entire board. Not chunk by chunk.
>>>
>>> You are not following properly release early, release often.
>>
>> Why this is still not included in initial submission which happens now?
>> Either you work Linux style (release early) or, if you decide to wait
>> till everything is ready, you submit board as one patch, not everything
>> as 100 different patches.
> 
> Hi Krzysztof, this audio change initial test is good with sound output and record fine. But with further test in Ubuntu gui only
> 2 speakers have sound output. I am still seeing why this issue is happening. I thought to solve the issues before replying
> and merging this, thanks.

Does not look like problem with kernel, though. If arecord and aplay, as
you imply in your first sentence, work then the code is fine and should
be squashed here.

Best regards,
Krzysztof