Message-ID: <nruypjmek7f76m5nbv6vs63koscrwcqknswfm67rkcjtqxpwhe@3ijzkbbaxj2p>
Date: Thu, 14 Aug 2025 14:27:59 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Yijie Yang <yijie.yang@....qualcomm.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Yingying Tang <quic_yintang@...cinc.com>,
        Shuai Zhang <quic_shuaz@...cinc.com>,
        Yongxing Mou <quic_yongmou@...cinc.com>
Subject: Re: [PATCH v5 0/3] Initial support for Qualcomm Hamoa IOT EVK board

On Thu, Aug 14, 2025 at 05:28:01PM +0800, Yijie Yang wrote:
> 
> 
> On 2025-08-14 17:05, Krzysztof Kozlowski wrote:
> > On 14/08/2025 10:54, Yijie Yang wrote:
> > > 
> > > 
> > > On 2025-08-14 16:24, Dmitry Baryshkov wrote:
> > > > On Thu, Aug 14, 2025 at 03:27:27PM +0800, Yijie Yang wrote:
> > > > > Introduce the device tree, DT bindings, and driver modifications required
> > > > > to bring up the HAMOA-IOT-EVK evaluation board—based on the X1E80100 SoC—to
> > > > > a UART shell.
> > > > > This patch set focuses on two key hardware components: the HAMOA-IOT-SOM
> > > > > and the HAMOA-IOT-EVK carrier board.
> > > > > The HAMOA-IOT-SOM is a compact System on Module that integrates the SoC,
> > > > > GPIOs, and PMICs. It is designed to be modular and can be paired with
> > > > > various carrier boards to support different use cases.
> > > > > The HAMOA-IOT-EVK is one such carrier board, designed for IoT scenarios.
> > > > > It provides essential peripherals such as UART, on-board PMICs, and
> > > > > USB-related components.
> > > > > Together, these components form a flexible and scalable platform, and this
> > > > > patch set enables their initial bring-up through proper device tree
> > > > > configuration and driver support.
> > > > > 
> > > > > Qualcomm SoCs often have multiple product variants, each identified by a
> > > > > different SoC ID. For instance, the x1e80100 SoC has closely related
> > > > > variants such as x1e78100 and x1e001de. This diversity in SoC identifiers
> > > > > can lead to confusion and unnecessary maintenance complexity in the device
> > > > > tree and related subsystems.
> > > > > To address this, code names offer a more consistent and project-agnostic
> > > > > way to represent SoC families. They tend to remain stable across
> > > > > development efforts.
> > > > > This patch series introduces "hamoa" as the codename for the x1e80100 SoC.
> > > > > Going forward, all x1e80100-related variants—including x1e81000 and others
> > > > > in the same family—will be represented under the "hamoa" designation in the
> > > > > device tree.
> > > > > This improves readability, streamlines future maintenance, and aligns with
> > > > > common naming practices across Qualcomm-based platforms.
> > > > > 
> > > > > Features added and enabled:
> > > > > - UART
> > > > > - On-board regulators
> > > > > - Regulators on the SOM
> > > > > - PMIC GLINK
> > > > > - USB0 through USB6 and their PHYs
> > > > > - Embedded USB (eUSB) repeaters
> > > > > - USB Type-C mux
> > > > > - PCIe6a and its PHY
> > > > > - PCIe4 and its PHY
> > > > > - Reserved memory regions
> > > > > - Pinctrl
> > > > > - NVMe
> > > > > - ADSP, CDSP
> > > > > - WLAN, Bluetooth (M.2 interface)
> > > > > - USB DisplayPort
> > > > > 
> > > > > DTS Dependency:
> > > > > https://lore.kernel.org/all/20250724-move-edp-endpoints-v1-3-6ca569812838@oss.qualcomm.com/
> > > > > 
> > > > > Signed-off-by: Yijie Yang <yijie.yang@....qualcomm.com>
> > > > > ---
> > > > > To: Bjorn Andersson <andersson@...nel.org>
> > > > > To: Konrad Dybcio <konradybcio@...nel.org>
> > > > > To: Rob Herring <robh@...nel.org>
> > > > > To: Krzysztof Kozlowski <krzk+dt@...nel.org>
> > > > > To: Conor Dooley <conor+dt@...nel.org>
> > > > > Cc: linux-arm-msm@...r.kernel.org
> > > > > Cc: devicetree@...r.kernel.org
> > > > > Cc: linux-kernel@...r.kernel.org
> > > > > 
> > > > > ---
> > > > > Changes in v5:
> > > > > - Update base commit.
> > > > > - Drop an already merged patch:
> > > > > https://lore.kernel.org/all/20250804-hamoa_initial-v4-2-19edbb28677b@oss.qualcomm.com/
> > > > > - Link to v4: https://lore.kernel.org/r/20250804-hamoa_initial-v4-0-19edbb28677b@oss.qualcomm.com
> > > > 
> > > > Please keep full changelog rather than trimming previous iterations.
> > > 
> > > Sure, I will restore them.
> > > 
> > > > 
> > > > Also, is there a reason why you didn't pick up audio and display chunks
> > > > as it was requested on the corresponding reviews?
> > > 
> > > Display-related changes have been merged into '[PATCH v5 3/3] arm64:
> > > dts: qcom: Add base HAMOA-IOT-EVK board' and are already present there.
> > > 
> > > Audio support is still under debugging due to unresolved issues, and
> > > it's unclear when it will be ready. Would it be acceptable to proceed
> > > without it for now?
> > Audio was sent to the lists, so this is confusing. What was the point of
> > that posting? It clearly said:
> > 
> > "Basic test is good in Hamoa-IOT-EVK board."
> 
> Additional issues with audio were discovered during further testing, and
> the current audio series on the list is not suitable to be merged into
> this series at this time.

What if the maintainer had picked up that series, with the issues?
If you uncover an issue, please respond to the patchset, descring that
it should not be merged (together with the reason and the description of
a problem).

> 
> > 
> > So was that true or not?
> > 
> > Best regards,
> > Krzysztof
> 
> -- 
> Best Regards,
> Yijie
> 

-- 
With best wishes
Dmitry

Powered by blists - more mailing lists