linux-kernel - Re: [PATCH v5 1/3] ACPI: RISC-V: Add support for RIMT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJ8RJCFM8p_GrFXk@sunil-laptop>
Date: Fri, 15 Aug 2025 16:21:16 +0530
From: Sunil V L <sunilvl@...tanamicro.com>
To: XianLiang Huang <huangxianliang@...xincomputing.com>
Cc: ajones@...tanamicro.com, alex@...ti.fr, anup@...infault.org,
	apatel@...tanamicro.com, atishp@...osinc.com, iommu@...ts.linux.dev,
	joro@...tes.org, lenb@...nel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
	palmer@...belt.com, paul.walmsley@...ive.com, rafael@...nel.org,
	robin.murphy@....com, tjeznach@...osinc.com, will@...nel.org
Subject: Re: [PATCH v5 1/3] ACPI: RISC-V: Add support for RIMT

On Fri, Aug 15, 2025 at 03:55:41PM +0800, XianLiang Huang wrote:
> Hi Sunil,
> 
> On Wed, 16 Jul 2025 16:10:57 +0530, Sunil V L wrote:
> > +	parent = ACPI_ADD_PTR(struct acpi_rimt_node, rimt_table, map->dest_offset);
> > +
> > +	if (node->type == ACPI_RIMT_NODE_TYPE_PLAT_DEVICE ||
> > +	    node->type == ACPI_RIMT_NODE_TYPE_PCIE_ROOT_COMPLEX) {
> > +		*id_out = map->dest_offset;
> > +		return parent;
> > +	}
> 
> Why do we assign dest_offset to id_out? The dest_offset is the iommu offset, not
> a valid deviceid required for platform device in rimt_plat_iommu_map?
> 
Good catch!. Thanks!. It should be dest_id_base. Let me fix it in next
revision.

Thanks!
Sunil