linux-kernel - Re: [PATCH] drm/panthor: Remove dead code in mmu_hw_do_operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f266ba8-d7a5-4f2d-aef8-a3c5b9b3a601@arm.com>
Date: Fri, 15 Aug 2025 12:25:00 +0100
From: Steven Price <steven.price@....com>
To: Daniel Stone <daniel@...ishbar.org>
Cc: Boris Brezillon <boris.brezillon@...labora.com>,
 Liviu Dudau <liviu.dudau@....com>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, Karunika Choo <karunika.choo@....com>,
 Chia-I Wu <olvaffe@...il.com>
Subject: Re: [PATCH] drm/panthor: Remove dead code in
 mmu_hw_do_operation_locked

On 15/08/2025 12:17, Daniel Stone wrote:
> Hi Steven,
> 
> On Fri, 15 Aug 2025 at 11:25, Steven Price <steven.price@....com> wrote:
>> The only callers to mmu_hw_do_operation_locked() pass an 'op' of either
>> AS_COMAND_FLUSH_MEM or AS_COMMAND_FLUSH_PT. So remove the code paths
>> that test for other operations and add a drm_WARN_ON() to catch the
>> posibility of others appearing the future.
> 
> Thanks! I think it would make sense to also inline
> mmu_hw_do_flush_on_gpu_ctrl() here though.

True, I'll have a go at a proper rewrite of that function to make it
more coherent.

Thanks,
Steve