linux-kernel - Re: [PATCH V3 2/4] drm/bridge: it66121: Drop ftrace like dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08eec1de-1c92-44ce-8caa-2dc43a67c514@ti.com>
Date: Fri, 15 Aug 2025 08:50:32 -0500
From: Andrew Davis <afd@...com>
To: Nishanth Menon <nm@...com>, Conor Dooley <conor+dt@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Rob Herring <robh@...nel.org>, David Airlie
	<airlied@...il.com>,
        Maxime Ripard <mripard@...nel.org>,
        Laurent Pinchart
	<Laurent.pinchart@...asonboard.com>,
        Neil Armstrong
	<neil.armstrong@...aro.org>
CC: <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>,
        Robert Nelson <robertcnelson@...il.com>,
        Jason Kridner <jkridner@...gleboard.org>,
        <tomi.valkeinen@...asonboard.com>, <devarsht@...com>
Subject: Re: [PATCH V3 2/4] drm/bridge: it66121: Drop ftrace like dev_dbg()
 prints

On 8/14/25 10:41 PM, Nishanth Menon wrote:
> Drop the ftrace like dev_dbg() that checkpatch --strict complains about:
> 
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> +	dev_dbg(dev, "%s\n", __func__);
> 
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> +	dev_dbg(dev, "%s\n", __func__);
> 
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> +	dev_dbg(dev, "%s\n", __func__);
> 
> Signed-off-by: Nishanth Menon <nm@...com>
> ---

Reviewed-by: Andrew Davis <afd@...com>

> Changes in V3:
> * New patch
> 
>   drivers/gpu/drm/bridge/ite-it66121.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
> index aa7b1dcc5d70..9b8ed2fae2f4 100644
> --- a/drivers/gpu/drm/bridge/ite-it66121.c
> +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> @@ -1384,8 +1384,6 @@ static int it66121_audio_startup(struct device *dev, void *data)
>   	int ret;
>   	struct it66121_ctx *ctx = dev_get_drvdata(dev);
>   
> -	dev_dbg(dev, "%s\n", __func__);
> -
>   	mutex_lock(&ctx->lock);
>   	ret = it661221_audio_output_enable(ctx, true);
>   	if (ret)
> @@ -1401,8 +1399,6 @@ static void it66121_audio_shutdown(struct device *dev, void *data)
>   	int ret;
>   	struct it66121_ctx *ctx = dev_get_drvdata(dev);
>   
> -	dev_dbg(dev, "%s\n", __func__);
> -
>   	mutex_lock(&ctx->lock);
>   	ret = it661221_audio_output_enable(ctx, false);
>   	if (ret)
> @@ -1479,8 +1475,6 @@ static int it66121_audio_codec_init(struct it66121_ctx *ctx, struct device *dev)
>   		.no_capture_mute = 1,
>   	};
>   
> -	dev_dbg(dev, "%s\n", __func__);
> -
>   	if (!of_property_present(dev->of_node, "#sound-dai-cells")) {
>   		dev_info(dev, "No \"#sound-dai-cells\", no audio\n");
>   		return 0;