linux-kernel - Re: [PATCH 19/80] drm/panfrost: Remove redundant pm_runtime_mark_last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4825140d-a03e-4b22-a7ed-1de17b07714e@arm.com>
Date: Fri, 15 Aug 2025 15:22:40 +0100
From: Steven Price <steven.price@....com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Boris Brezillon <boris.brezillon@...labora.com>,
 Rob Herring <robh@...nel.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/80] drm/panfrost: Remove redundant
 pm_runtime_mark_last_busy() calls

On 04/07/2025 10:18, Steven Price wrote:
> On 04/07/2025 08:54, Sakari Ailus wrote:
>> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
>> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
>> to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
>> pm_runtime_mark_last_busy().
>>
>> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> 
> Reviewed-by: Steven Price <steven.price@....com>
> 
> But this can't be merged via drm-misc until the PM changes have hit
> Linus' tree and been backmerged to drm-misc-next.

The back merged of -rc1 happened, so I've now merged this to drm-misc-next.

Thanks,
Steve

> Thanks,
> Steve
> 
>> ---
>> The cover letter of the set can be found here
>> <URL:https://lore.kernel.org/linux-pm/20250704075225.3212486-1-sakari.ailus@linux.intel.com>.
>>
>> In brief, this patch depends on PM runtime patches adding marking the last
>> busy timestamp in autosuspend related functions. The patches are here, on
>> rc2:
>>
>>         git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \
>>                 pm-runtime-6.17-rc1
>>
>>  drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c
>> index 563f16bae543..0dd62e8b2fa7 100644
>> --- a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c
>> +++ b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c
>> @@ -203,7 +203,6 @@ static int panfrost_perfcnt_disable_locked(struct panfrost_device *pfdev,
>>  	panfrost_mmu_as_put(pfdev, perfcnt->mapping->mmu);
>>  	panfrost_gem_mapping_put(perfcnt->mapping);
>>  	perfcnt->mapping = NULL;
>> -	pm_runtime_mark_last_busy(pfdev->dev);
>>  	pm_runtime_put_autosuspend(pfdev->dev);
>>  
>>  	return 0;
>> @@ -279,7 +278,6 @@ void panfrost_perfcnt_close(struct drm_file *file_priv)
>>  	if (perfcnt->user == pfile)
>>  		panfrost_perfcnt_disable_locked(pfdev, file_priv);
>>  	mutex_unlock(&perfcnt->lock);
>> -	pm_runtime_mark_last_busy(pfdev->dev);
>>  	pm_runtime_put_autosuspend(pfdev->dev);
>>  }
>>  
>