linux-kernel - Re: [PATCH v3] kdb: Replace deprecated strcpy() with strscpy() and memcpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <73C106D1-C7F8-415C-9BC2-89607C839265@linux.dev>
Date: Fri, 15 Aug 2025 16:40:56 +0200
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Daniel Thompson <daniel@...cstar.com>
Cc: Jason Wessel <jason.wessel@...driver.com>,
 Daniel Thompson <danielt@...nel.org>,
 Douglas Anderson <dianders@...omium.org>,
 Nir Lichtman <nir@...htman.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Yuran Pereira <yuran.pereira@...mail.com>,
 linux-hardening@...r.kernel.org,
 kgdb-bugreport@...ts.sourceforge.net,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] kdb: Replace deprecated strcpy() with strscpy() and
 memcpy()

On 15. Aug 2025, at 16:29, Daniel Thompson wrote:
> 
> I like the extra diligence of checking the trailing quote but perhaps
> combine the two if statements (so we only chomp the quotes if there
> are two).

Ok.

Should I replace kdb_strdup() with kdb_strdup_dequote() because it also
handles unquoted strings or do we want to keep both versions? It's only
used in a few places where kdb_strdup_dequote() would also work.

Thanks,
Thorsten