linux-kernel - Re: [PATCH V3 3/4] drm/bridge: it66121: Use vid/pid to detect the type of chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250815152238.culfazudi4le2ykt@gravy>
Date: Fri, 15 Aug 2025 10:22:38 -0500
From: Nishanth Menon <nm@...com>
To: Andrew Davis <afd@...com>
CC: Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Rob Herring <robh@...nel.org>, David Airlie
	<airlied@...il.com>,
        Maxime Ripard <mripard@...nel.org>,
        Laurent Pinchart
	<Laurent.pinchart@...asonboard.com>,
        Neil Armstrong
	<neil.armstrong@...aro.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>,
        Robert
 Nelson <robertcnelson@...il.com>,
        Jason Kridner <jkridner@...gleboard.org>,
        <tomi.valkeinen@...asonboard.com>, <devarsht@...com>
Subject: Re: [PATCH V3 3/4] drm/bridge: it66121: Use vid/pid to detect the
 type of chip

On 08:52-20250815, Andrew Davis wrote:
> > This also allows for some future compatibility to be checked only
> > against a restricted set of vid/pid.

^^ See below

> >   static const struct of_device_id it66121_dt_match[] = {
> > -	{ .compatible = "ite,it66121", &it66121_chip_info },
> > -	{ .compatible = "ite,it6610", &it6610_chip_info },
> > +	{ .compatible = "ite,it66121", &it66xx_chip_info },
> > +	{ .compatible = "ite,it6610", &it66xx_chip_info },
> 
> If you will pass in the same data to all devices, just don't pass
> anything. Move the it66121_dt_match table up above probe, and just
> use it, no need for fetching it from i2c_get_match_data().

(rationale in commit messsage)
Yeah, I was going to do that, but this vendor has a bunch of devices and
I am not able to see all possible combinations.. so was thinking that
maybe some combination device will need different checks with a limited
vid/pid list.. just lack of public documentation makes me a bit
paranoid.

I am not tied to this that hard (it was a "meh"), so if folks feel this
can be thrown out, can respin.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource