linux-kernel - Re: [RFC net-next v3 7/7] net: devmem: allow binding on rx queues with same MA devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250815102433.740eb2a6@kernel.org>
Date: Fri, 15 Aug 2025 10:24:33 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Dragos Tatulea <dtatulea@...dia.com>
Cc: <almasrymina@...gle.com>, <asml.silence@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, <cratiu@...dia.com>,
 <tariqt@...dia.com>, <parav@...dia.com>, Christoph Hellwig
 <hch@...radead.org>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [RFC net-next v3 7/7] net: devmem: allow binding on rx queues
 with same MA devices

On Fri, 15 Aug 2025 14:03:48 +0300 Dragos Tatulea wrote:
> +		rxq_dma_dev = netdev_queue_get_dma_dev(netdev, rxq_idx);
> +		/* Multi-PF netdev queues can belong to different DMA devoces.
> +		 * Block this case.
> +		 */
> +		if (rxq_dma_dev && dma_dev && rxq_dma_dev != dma_dev) {

Why rxq_dma_dev ? 🤔️
Don't we want to error out if the first queue gave us a DMA dev but the
second gave us a NULL ?

> +			NL_SET_ERR_MSG(extack, "Can't bind to queues from different dma devices");

_FMT the conflicting queue IDs into this?