linux-kernel - Re: [PATCH net-next 1/2] net: phy: mxl-86110: add basic support for led_brightness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d3a0eb3b-933f-4451-801a-e8ceb17f5953@lunn.ch>
Date: Fri, 15 Aug 2025 19:25:34 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Xu Liang <lxu@...linear.com>, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: phy: mxl-86110: add basic support for
 led_brightness_set op

> +	phy_lock_mdio_bus(phydev);
> +
> +	ret =  __mxl86110_modify_extended_reg(phydev,
> +					      MXL86110_COM_EXT_LED_GEN_CFG,
> +					      MXL86110_COM_EXT_LED_GEN_CFG_LFE(index),
> +					      0);
> +
> +	phy_unlock_mdio_bus(phydev);

Please add a mxl86110_modify_extended_reg() which does the
locking. There is already mxl86110_write_extended_reg() and
mxl86110_read_extended_reg().

    Andrew

---
pw-bot: cr