linux-kernel - Re: [PATCH net-next v13 4/5] net: ti: prueth: Adds link detection, RX and TX support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250815115956.0f36ae06@kernel.org>
Date: Fri, 15 Aug 2025 11:59:56 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Parvathi Pudi <parvathi@...thit.com>
Cc: danishanwar@...com, rogerq@...nel.org, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 ssantosh@...nel.org, richardcochran@...il.com, m-malladi@...com,
 s.hauer@...gutronix.de, afd@...com, jacob.e.keller@...el.com,
 horms@...nel.org, johan@...nel.org, m-karicheri2@...com, s-anna@...com,
 glaroque@...libre.com, saikrishnag@...vell.com, kory.maincent@...tlin.com,
 diogo.ivo@...mens.com, javier.carrasco.cruz@...il.com,
 basharath@...thit.com, linux-arm-kernel@...ts.infradead.org,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, vadim.fedorenko@...ux.dev,
 alok.a.tiwari@...cle.com, bastien.curutchet@...tlin.com, pratheesh@...com,
 prajith@...com, vigneshr@...com, praneeth@...com, srk@...com,
 rogerq@...com, krishna@...thit.com, pmohan@...thit.com, mohan@...thit.com
Subject: Re: [PATCH net-next v13 4/5] net: ti: prueth: Adds link detection,
 RX and TX support.

On Tue, 12 Aug 2025 19:04:19 +0530 Parvathi Pudi wrote:
> +static irqreturn_t icssm_emac_rx_packets(struct prueth_emac *emac, int quota)

Please stick to calling the budget budget rather than synonym terms
like "quota". Makes it harder to review the code.

> +	/* search host queues for packets */
> +	for (i = start_queue; i <= end_queue; i++) {
> +		queue_desc = emac->rx_queue_descs + i;
> +		rxqueue = &queue_infos[PRUETH_PORT_HOST][i];

budget can be 0, in which case the driver is not supposed to process
Rx, just Tx (if the NAPI instance is used to serve completions).

> +	num_rx_packets = icssm_emac_rx_packets(emac, budget);
> +	if (num_rx_packets < budget) {
> +		napi_complete_done(napi, num_rx_packets);

don't ignore the return value of napi_complete_done()
-- 
pw-bot: cr