linux-kernel - Re: [PATCH v2] media: atomisp: Add lock asserts for mutex protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJ-StLSBnHmHHGUX@stanley.mountain>
Date: Fri, 15 Aug 2025 23:04:04 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Abdelrahman Fekry <abdelrahmanfekry375@...il.com>
Cc: hansg@...nel.org, mchehab@...nel.org, sakari.ailus@...ux.intel.com,
	andy@...nel.org, gregkh@...uxfoundation.org,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev, linux-kernel-mentees@...ts.linux.dev,
	skhan@...uxfoundation.org, Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH v2] media: atomisp: Add lock asserts for mutex protection

On Fri, Aug 15, 2025 at 09:24:11PM +0300, Abdelrahman Fekry wrote:
> Add lockdep_assert_held(&isp->mutex) to critical functions accessing
> shared device state. This enforces proper locking and detects violations.
> 
> Suggested-by: Hans de Goede <hdegoede@...hat.com>
> Signed-off-by: Abdelrahman Fekry <abdelrahmanfekry375@...il.com>
> 
> ---
> v2:
> - Fix Typos
> - tested by building the driver
> 
> v1: https://lore.kernel.org/all/20250815170901.32105-1-abdelrahmanfekry375@gmail.com/

Same comments.  Best to wait a day between resends.

regards,
dan carpenter