linux-kernel - Re: [PATCH] perf session: Fix handling when buffer exceeds 2 GiB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJ-V2ZsYpN8RDQ3M@google.com>
Date: Fri, 15 Aug 2025 13:17:29 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Leo Yan <leo.yan@....com>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tamas Zsoldos <tamas.zsoldos@....com>
Subject: Re: [PATCH] perf session: Fix handling when buffer exceeds 2 GiB

On Fri, Aug 08, 2025 at 02:24:40PM +0100, Leo Yan wrote:
> If a user specifies an AUX buffer larger than 2 GiB, the returned size
> may exceed 0x80000000. Since the err variable is defined as a signed
> 32-bit integer, such a value overflows and becomes negative.
> 
> As a result, the perf record command reports an error:
> 
>   0x146e8 [0x30]: failed to process type: 71 [Unknown error 183711232]
> 
> Change the type of the err variable to a signed 64-bit integer to
> accommodate large buffer sizes correctly.
> 
> Reported-by: Tamas Zsoldos <tamas.zsoldos@....com>
> Fixes: d5652d865ea7 ("perf session: Add ability to skip 4GiB or more")
> Signed-off-by: Leo Yan <leo.yan@....com>

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung

> ---
>  tools/perf/util/session.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 26ae078278cd67fc5894c01cbb44c4b8fa81321a..09af486c83e4ff82e74f17f3da08d3bc3989768b 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1402,7 +1402,7 @@ static s64 perf_session__process_user_event(struct perf_session *session,
>  	const struct perf_tool *tool = session->tool;
>  	struct perf_sample sample;
>  	int fd = perf_data__fd(session->data);
> -	int err;
> +	s64 err;
>  
>  	perf_sample__init(&sample, /*all=*/true);
>  	if ((event->header.type != PERF_RECORD_COMPRESSED &&
> 
> ---
> base-commit: 6235ce77749f45cac27f630337e2fdf04e8a6c73
> change-id: 20250808-perf_fix_big_buffer_size-e28f618df61c
> 
> Best regards,
> -- 
> Leo Yan <leo.yan@....com>
>