linux-kernel - Re: [PATCH] perf build: Allow using compiler wrappers with CLANG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJ-XAEGNnecMKgj9@google.com>
Date: Fri, 15 Aug 2025 13:22:24 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Ilya Leoshkevich <iii@...ux.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	Heiko Carstens <hca@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Thomas Richter <tmricht@...ux.ibm.com>
Subject: Re: [PATCH] perf build: Allow using compiler wrappers with CLANG

On Tue, Aug 05, 2025 at 02:09:34PM +0200, Ilya Leoshkevich wrote:
> It is useful to specify CLANG="ccache clang" in order to speed up
> builds. Unfortunately perf's compiler detection logic does not like
> this:
> 
>     Makefile.config:704: Warning: Disabled BPF skeletons as clang (ccache clang) is missing
> 
> We don't need to know the full path to $(CLANG), so using
> get-executable is not necessary. Fix by trying to run
> `$(CLANG) --version` instead.
> 
> Signed-off-by: Ilya Leoshkevich <iii@...ux.ibm.com>

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung

> ---
>  tools/perf/Makefile.config | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index 5a5832ee7b53..4bc11db5aa4d 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -700,7 +700,7 @@ ifeq ($(BUILD_BPF_SKEL),1)
>    else ifeq ($(filter -DHAVE_LIBBPF_SUPPORT, $(CFLAGS)),)
>      $(warning Warning: Disabled BPF skeletons as libbpf is required)
>      BUILD_BPF_SKEL := 0
> -  else ifeq ($(call get-executable,$(CLANG)),)
> +  else ifneq ($(shell $(CLANG) --version >/dev/null 2>&1; echo $$?),0)
>      $(warning Warning: Disabled BPF skeletons as clang ($(CLANG)) is missing)
>      BUILD_BPF_SKEL := 0
>    else
> -- 
> 2.50.1
>