linux-kernel - Re: [PATCH v4 2/5] net: rnpgbe: Add n500/n210 chip support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f91565ea-e648-4b7d-9920-0d3d792020e6@lunn.ch>
Date: Fri, 15 Aug 2025 04:07:25 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Yibo Dong <dong100@...se.com>
Cc: MD Danish Anwar <danishanwar@...com>, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, horms@...nel.org, corbet@....net,
	gur.stavi@...wei.com, maddy@...ux.ibm.com, mpe@...erman.id.au,
	lee@...ger.us, gongfan1@...wei.com, lorenzo@...nel.org,
	geert+renesas@...der.be, Parthiban.Veerasooran@...rochip.com,
	lukas.bulwahn@...hat.com, alexanderduyck@...com,
	richardcochran@...il.com, netdev@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/5] net: rnpgbe: Add n500/n210 chip support

> > > +static void rnpgbe_init_n500(struct mucse_hw *hw)
> > > +{
> > > +	struct mucse_mbx_info *mbx = &hw->mbx;
> > > +
> > > +	rnpgbe_init_common(hw);
> > > +
> > > +	mbx->fw2pf_mbox_vec = 0x28b00;
> > > +	mbx->fw_pf_shm_base = 0x2d000;
> > > +	mbx->pf2fw_mbox_ctrl = 0x2e000;
> > > +	mbx->fw_pf_mbox_mask = 0x2e200;
> > > +	hw->ring_msix_base = hw->hw_addr + 0x28700;
> > > +	hw->usecstocount = 125;
> > > +}
> > 
> > These hardcoded values should be defined in rnpgbe_hw.h as macros rather
> > than using magic numbers.
> > 
> 
> Got it, I will update this.

You might also want to talk to your hardware engineers and tell them
not to make silly changes like this between hardware versions. It just
makes the software harder for no reason.

      Andrew