linux-kernel - Re: [PATCH v4 2/5] selftests/mm: mark all functions static in split_huge_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <219CDAAB-2571-4F47-815C-96A41F8D4410@gmail.com>
Date: Fri, 15 Aug 2025 11:26:43 +0800
From: wang lian <lianux.mm@...il.com>
To: Zi Yan <ziy@...dia.com>
Cc: Wei Yang <richard.weiyang@...il.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 David Hildenbrand <david@...hat.com>,
 linux-mm@...ck.org,
 Andrew Morton <akpm@...ux-foundation.org>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>,
 Nico Pache <npache@...hat.com>,
 Ryan Roberts <ryan.roberts@....com>,
 Dev Jain <dev.jain@....com>,
 Barry Song <baohua@...nel.org>,
 Vlastimil Babka <vbabka@...e.cz>,
 Mike Rapoport <rppt@...nel.org>,
 Suren Baghdasaryan <surenb@...gle.com>,
 Michal Hocko <mhocko@...e.com>,
 Shuah Khan <shuah@...nel.org>,
 linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v4 2/5] selftests/mm: mark all functions static in
 split_huge_page_test.c



> On Aug 15, 2025, at 10:39, Zi Yan <ziy@...dia.com> wrote:
> 
> All functions are only used within the file.
> 
> Signed-off-by: Zi Yan <ziy@...dia.com>
> ---
> .../selftests/mm/split_huge_page_test.c       | 22 +++++++++----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c
> index 5d07b0b89226..89d3dc08fe4c 100644
> --- a/tools/testing/selftests/mm/split_huge_page_test.c
> +++ b/tools/testing/selftests/mm/split_huge_page_test.c
> @@ -38,7 +38,7 @@ uint64_t pmd_pagesize;
> #define KPF_THP      (1UL<<22)
> #define GET_ORDER(nr_pages)    (31 - __builtin_clz(nr_pages))
> 
> -int is_backed_by_thp(char *vaddr, int pagemap_file, int kpageflags_file)
> +static int is_backed_by_thp(char *vaddr, int pagemap_file, int kpageflags_file)
> {
> 	uint64_t paddr;
> 	uint64_t page_flags;
> @@ -136,7 +136,7 @@ static void verify_rss_anon_split_huge_page_all_zeroes(char *one_page, int nr_hp
> 		       rss_anon_before, rss_anon_after);
> }
> 
> -void split_pmd_zero_pages(void)
> +static void split_pmd_zero_pages(void)
> {
> 	char *one_page;
> 	int nr_hpages = 4;
> @@ -148,7 +148,7 @@ void split_pmd_zero_pages(void)
> 	free(one_page);
> }
> 
> -void split_pmd_thp_to_order(int order)
> +static void split_pmd_thp_to_order(int order)
> {
> 	char *one_page;
> 	size_t len = 4 * pmd_pagesize;
> @@ -182,7 +182,7 @@ void split_pmd_thp_to_order(int order)
> 	free(one_page);
> }
> 
> -void split_pte_mapped_thp(void)
> +static void split_pte_mapped_thp(void)
> {
> 	char *one_page, *pte_mapped, *pte_mapped2;
> 	size_t len = 4 * pmd_pagesize;
> @@ -265,7 +265,7 @@ void split_pte_mapped_thp(void)
> 	close(kpageflags_fd);
> }
> 
> -void split_file_backed_thp(int order)
> +static void split_file_backed_thp(int order)
> {
> 	int status;
> 	int fd;
> @@ -365,7 +365,7 @@ void split_file_backed_thp(int order)
> 	ksft_exit_fail_msg("Error occurred\n");
> }
> 
> -bool prepare_thp_fs(const char *xfs_path, char *thp_fs_template,
> +static bool prepare_thp_fs(const char *xfs_path, char *thp_fs_template,
> 		const char **thp_fs_loc)
> {
> 	if (xfs_path) {
> @@ -381,7 +381,7 @@ bool prepare_thp_fs(const char *xfs_path, char *thp_fs_template,
> 	return true;
> }
> 
> -void cleanup_thp_fs(const char *thp_fs_loc, bool created_tmp)
> +static void cleanup_thp_fs(const char *thp_fs_loc, bool created_tmp)
> {
> 	int status;
> 
> @@ -394,8 +394,8 @@ void cleanup_thp_fs(const char *thp_fs_loc, bool created_tmp)
> 				   strerror(errno));
> }
> 
> -int create_pagecache_thp_and_fd(const char *testfile, size_t fd_size, int *fd,
> -		char **addr)
> +static int create_pagecache_thp_and_fd(const char *testfile, size_t fd_size,
> +		int *fd, char **addr)
> {
> 	size_t i;
> 	unsigned char buf[1024];
> @@ -461,8 +461,8 @@ int create_pagecache_thp_and_fd(const char *testfile, size_t fd_size, int *fd,
> 	return -1;
> }
> 
> -void split_thp_in_pagecache_to_order_at(size_t fd_size, const char *fs_loc,
> -		int order, int offset)
> +static void split_thp_in_pagecache_to_order_at(size_t fd_size,
> +		const char *fs_loc, int order, int offset)
> {
> 	int fd;
> 	char *addr;
> -- 
> 2.50.1

LGTM.
Reviewed-by: wang lian <lianux.mm@...il.com>