linux-kernel - Re: [PATCH v2] rust: lib: add if_cfg! macro for conditional compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DC2UP1Q4D5L3.2SOGYHJGXPTWS@kernel.org>
Date: Fri, 15 Aug 2025 10:16:07 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@...il.com>, "Areej Hamid"
 <areejhamid8560@...il.com>
Cc: <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <ojeda@...nel.org>, <alex.gaynor@...il.com>, <boqun.feng@...il.com>,
 <gary@...yguo.net>, <bjorn3_gh@...tonmail.com>, <a.hindborg@...aro.org>,
 <aliceryhl@...gle.com>, <tmgross@...ch.edu>, <dakr@...nel.org>,
 <viresh.kumar@...aro.org>, <tamird@...il.com>,
 <dingxiangfei2009@...il.com>, <gregkh@...uxfoundation.org>,
 <thomas.weissschuh@...ain.com>
Subject: Re: [PATCH v2] rust: lib: add if_cfg! macro for conditional
 compilation

On Thu Aug 14, 2025 at 8:49 PM CEST, Miguel Ojeda wrote:
> By the way, Tamir suggested in the linked Rust for Linux issue to
> match the name of the upstream one in case we want to migrate to the
> standard library one eventually. In the commit message, I would also
> mention this and link to the tracking issue that Trevor mentioned:
> https://github.com/rust-lang/rust/issues/115585.

Didn't we also want to vendor the `cfg-if` crate? Or am I missing
something?

> Finally, we may want to consider putting this into somewhere else,
> rather than the root file of the crate.

Yeah, let's have it in a `cfg_if.rs` or whatever the macro will be
called.

---
Cheers,
Benno