linux-kernel - Re: [PATCH v5 07/18] rust: configfs: re-export `configfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ikipdm3o.fsf@t14s.mail-host-address-is-not-set>
Date: Fri, 15 Aug 2025 10:29:15 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Boqun Feng <boqun.feng@...il.com>, Miguel Ojeda <ojeda@...nel.org>, Alex
 Gaynor <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>, Björn Roy
 Baron <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>, Trevor
 Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, Jens Axboe
 <axboe@...nel.dk>, Breno Leitao <leitao@...ian.org>,
 linux-block@...r.kernel.org, rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 07/18] rust: configfs: re-export `configfs_attrs`
 from `configfs` module

"Alice Ryhl" <aliceryhl@...gle.com> writes:

> On Fri, Aug 15, 2025 at 09:30:42AM +0200, Andreas Hindborg wrote:
>> Re-export `configfs_attrs` from `configfs` module, so that users can import
>> the macro from the `configfs` module rather than the root of the `kernel`
>> crate.
>>
>> Also update users to import from the new path.
>>
>> Signed-off-by: Andreas Hindborg <a.hindborg@...nel.org>
>
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
>
>>  rust/kernel/configfs.rs       | 2 ++
>>  samples/rust/rust_configfs.rs | 2 +-
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/rust/kernel/configfs.rs b/rust/kernel/configfs.rs
>> index 2736b798cdc6..0ca35ca8acb8 100644
>> --- a/rust/kernel/configfs.rs
>> +++ b/rust/kernel/configfs.rs
>> @@ -121,6 +121,8 @@
>>  use core::cell::UnsafeCell;
>>  use core::marker::PhantomData;
>>
>> +pub use crate::configfs_attrs;
>
> In other re-exports of macros, we've placed it immediately after the
> macro_rules! declaration.

Ok, makes sense. I'll move it.


Best regards,
Andreas Hindborg