linux-kernel - Re:Re: [PATCH] null_blk: Fix correct parameter desc for the module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30445c6a.6920.198acef8f24.Coremail.zhanggenjian@126.com>
Date: Fri, 15 Aug 2025 16:53:57 +0800 (CST)
From: "genjian zhang" <zhanggenjian@....com>
To: "Damien Le Moal" <dlemoal@...nel.org>
Cc: axboe@...nel.dk, shinichiro.kawasaki@....com, johannes.thumshirn@....com,
	kch@...dia.com, zhengqixing@...wei.com, willy@...radead.org,
	namcao@...utronix.de, vincent.fu@...sung.com,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Genjian Zhang" <zhanggenjian@...inos.cn>
Subject: Re:Re: [PATCH] null_blk: Fix correct parameter desc for the module


At 2025-08-15 13:23:50, "Damien Le Moal" <dlemoal@...nel.org> wrote:
>On 8/15/25 13:30, Genjian wrote:
>> From: Genjian Zhang <zhanggenjian@...inos.cn>
>
>The patch title is a little strange. What about:
>
>null_blk: Fix the description of the cache_size module argument
>
>> 
>> When executing modinfo null_blk, there is an error in the description
>> of module parameter mbps, and the output information of cache_size is
>> incomplete.The output of modinfo before and after applying this patch
>> is as follows:
>> 
>> Before:
>> [...]
>> parm:           cache_size:ulong
>> [...]
>> parm:           mbps:Cache size in MiB for memory-backed device.
>> 		Default: 0 (none) (uint)
>> [...]
>> 
>> After:
>> [...]
>> parm:           cache_size:Cache size in MiB for memory-backed device.
>> 		Default: 0 (none) (ulong)
>> [...]
>> parm:           mbps:Limit maximum bandwidth (in MiB/s).
>> 		Default: 0 (no limit) (uint)
>> [...]
>> 
>> Fixes: 058efe000b31 ("null_blk: add module parameters for 4 options")
>> 
>
>Remove the blank line here.
>
>> Signed-off-by: Genjian Zhang <zhanggenjian@...inos.cn>
>
>With these fixed,
>
>Reviewed-by: Damien Le Moal <dlemoal@...nel.org>
>
>-- 
>Damien Le Moal
>Western Digital Research

Thank you for your suggestions. I will send a patch v2.

-- 
Genjian