linux-kernel - Re: [PATCH v10 01/10] drm/mediatek: mtk_hdmi: Drop redundant clock retrieval in mtk_hdmi_get_cec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <feabc447d5030d5fc727c4f890e470efc111e40b.camel@mediatek.com>
Date: Fri, 15 Aug 2025 09:22:18 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>, "AngeloGioacchino Del
 Regno" <angelogioacchino.delregno@...labora.com>, "airlied@...il.com"
	<airlied@...il.com>, Louis-Alexis Eyraud <louisalexis.eyraud@...labora.com>,
	"simona@...ll.ch" <simona@...ll.ch>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "kernel@...labora.com"
	<kernel@...labora.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 01/10] drm/mediatek: mtk_hdmi: Drop redundant clock
 retrieval in mtk_hdmi_get_cec_dev

On Fri, 2025-08-08 at 12:12 +0200, Louis-Alexis Eyraud wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> In mtk_hdmi driver, when the CEC device parsing logic was moved from
> mtk_hdmi_dt_parse_pdata function to the new mtk_hdmi_get_cec_dev sub
> function, the call to mtk_hdmi_get_all_clk was kept in both functions,
> whereas it was only called once in the original mtk_hdmi_dt_parse_pdata
> code and does not need to be called a second time.
> So, remove this call from mtk_hdmi_get_cec_dev to keep the same sequence
> as previously.

Reviewed-by: CK Hu <ck.hu@...iatek.com>

> 
> Fixes: 7485be967f7f ("drm/mediatek: mtk_hdmi: Move CEC device parsing in new function")
> Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@...labora.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_hdmi.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index 845fd8aa43c3c91659808d9e6bb78758d1f9b857..0ac4e755bdf8aace766feffa57712a8fbf4ff791 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1349,11 +1349,6 @@ static int mtk_hdmi_get_cec_dev(struct mtk_hdmi *hdmi, struct device *dev, struc
>  {
>         struct platform_device *cec_pdev;
>         struct device_node *cec_np;
> -       int ret;
> -
> -       ret = mtk_hdmi_get_all_clk(hdmi, np);
> -       if (ret)
> -               return dev_err_probe(dev, ret, "Failed to get clocks\n");
> 
>         /* The CEC module handles HDMI hotplug detection */
>         cec_np = of_get_compatible_child(np->parent, "mediatek,mt8173-cec");
> 
> --
> 2.50.1
>