linux-kernel - Re: [PATCH] fwctl: mlx5: fix memory alloc/free in mlx5ctl_fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aKAMZenB2iqSSfd3@bhairav-test.ee.iitb.ac.in>
Date: Sat, 16 Aug 2025 10:13:17 +0530
From: Akhilesh Patil <akhilesh@...iitb.ac.in>
To: Markus Elfring <Markus.Elfring@....de>
Cc: akhileshpatilvnit@...il.com, LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org, Dave Jiang <dave.jiang@...el.com>,
	Itay Avraham <itayavr@...dia.com>, Jason Gunthorpe <jgg@...pe.ca>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Saeed Mahameed <saeedm@...dia.com>,
	Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] fwctl: mlx5: fix memory alloc/free in mlx5ctl_fw_rpc()

On Fri, Aug 15, 2025 at 04:40:10PM +0200, Markus Elfring wrote:
> > Use kvfree() to free memory allocated by kvzalloc() instead of kfree().
> > Avoid potential memory management issue by matching alloc/free routines.
> 
> Will another bit of background information become helpful
> for an improved change description?
> 
> Test command example:
> Markus_Elfring@...ne:…/Projekte/Linux/next-analyses> /usr/bin/spatch -D report scripts/coccinelle/api/kfree_mismatch.cocci drivers/fwctl/mlx5/main.c

Sure, I will update the commit message to add this and push v2.
Thanks Markus for the suggestion. 

Regards,
Akhilesh

> …
> 
> Regards,
> Markus