linux-kernel - Re: [PATCH v5 12/14] RDMA/ionic: Register device ops for miscellaneous functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44ff453d-3c85-2303-44a7-a6a2e48f8adf@amd.com>
Date: Sat, 16 Aug 2025 13:41:30 +0530
From: Abhijit Gangurde <abhijit.gangurde@....com>
To: Shay Drori <shayd@...dia.com>
Cc: sln@...main.com, allen.hubbe@....com, nikhil.agarwal@....com,
 linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 andrew+netdev@...n.ch, Andrew Boyer <andrew.boyer@....com>,
 brett.creeley@....com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, corbet@....net, jgg@...pe.ca,
 leon@...nel.org
Subject: Re: [PATCH v5 12/14] RDMA/ionic: Register device ops for
 miscellaneous functionality


On 8/14/25 17:02, Shay Drori wrote:
>
>
> On 14/08/2025 8:38, Abhijit Gangurde wrote:
>> @@ -50,6 +251,17 @@ static const struct ib_device_ops ionic_dev_ops = {
>>       .poll_cq = ionic_poll_cq,
>>       .req_notify_cq = ionic_req_notify_cq,
>>   +    .query_device = ionic_query_device,
>> +    .query_port = ionic_query_port,
>> +    .get_link_layer = ionic_get_link_layer,
>> +    .query_pkey = ionic_query_pkey,
>> +    .modify_device = ionic_modify_device,
>> +    .get_port_immutable = ionic_get_port_immutable,
>> +    .get_dev_fw_str = ionic_get_dev_fw_str,
>> +    .get_vector_affinity = ionic_get_vector_affinity,
>
> I see there is no usage of get_vector_affinity(). It is called from
> ib_get_vector_affinity() and no one is calling ib_get_vector_affinity().
>
> So, in case you re-spin the series, can you drop it?
>
> Thanks
> Shay
>
>> +    .device_group = &ionic_rdma_attr_group,
>> +    .disassociate_ucontext = ionic_disassociate_ucontext,
>> +
>>       INIT_RDMA_OBJ_SIZE(ib_ucontext, ionic_ctx, ibctx),
>>       INIT_RDMA_OBJ_SIZE(ib_pd, ionic_pd, ibpd),
>>       INIT_RDMA_OBJ_SIZE(ib_ah, ionic_ah, ibah),
>
Sure. I'll drop it in the next spin.

Thanks,
Abhijit