linux-kernel - Re: [PATCH 2/3] dt-bindings: net: Add support for J-Core EMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa6bdc05-81b0-49a2-9d0d-8302fa66bf35@kernel.org>
Date: Sat, 16 Aug 2025 10:19:58 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Artur Rojek <contact@...ur-rojek.eu>, Rob Landley <rob@...dley.net>,
 Jeff Dionne <jeff@...esemi.io>,
 John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: net: Add support for J-Core EMAC

On 15/08/2025 21:48, Artur Rojek wrote:
> Add a documentation file to describe the Device Tree bindings for the
> Ethernet Media Access Controller found in the J-Core family of SoCs.
> 
> Signed-off-by: Artur Rojek <contact@...ur-rojek.eu>
> ---
>  .../devicetree/bindings/net/jcore,emac.yaml   | 42 +++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/jcore,emac.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/jcore,emac.yaml b/Documentation/devicetree/bindings/net/jcore,emac.yaml
> new file mode 100644
> index 000000000000..a4384f7ed83d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/jcore,emac.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/jcore,emac.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: J-Core Ethernet Media Access Controller
> +
> +description: |
> +  This node provides properties for configuring the Ethernet MAC found
> +  in the J-Core family of SoCs.
> +
> +maintainers:
> +  - Artur Rojek <contact@...ur-rojek.eu>
> +
> +properties:
> +  compatible:
> +    const: jcore,emac

You need SoC-based compatibles. And then also rename the file to match it.

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +allOf:
> +  - $ref: ethernet-controller.yaml#
> +
> +additionalProperties: false

unevaluatedProperties instead

> +
> +examples:
> +  - |
> +    ethernet@...00 {
> +      compatible = "jcore,emac";
> +      reg = <0x10000 0x2000>;
> +      interrupts = <0x11>;

That's not hex...

> +    };

Best regards,
Krzysztof