linux-kernel - Re: [PATCH 1/3] crypto: hisilicon/zip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKBL7MF2_NRUc9so@gondor.apana.org.au>
Date: Sat, 16 Aug 2025 17:14:20 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Chenghai Huang <huangchenghai2@...wei.com>
Cc: davem@...emloft.net, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, liulongfang@...wei.com,
	taoqi10@...wei.com, qianweili@...wei.com, wangzhou1@...ilicon.com
Subject: Re: [PATCH 1/3] crypto: hisilicon/zip - support fallback for zip

On Sat, Aug 09, 2025 at 03:08:27PM +0800, Chenghai Huang wrote:
>
> +err_out:
> +	if (acomp_req->base.complete)
> +		acomp_request_complete(acomp_req, ret);

First of all you should never check acomp_req->base.complete.
It must be non-NULL for an async driver.

More importantly, you shouldn't even be invoking the callback
function here.  The callback is only to be called after an async
return with -EINPROGRESS.  Since this code path never returned an
-EINPROGRESS in the first place, it must not call the callback.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt