linux-kernel - Re: [PATCH v2] crypto: caam - switch to use devm_kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKBNn7qgBVhJcLhq@gondor.apana.org.au>
Date: Sat, 16 Aug 2025 17:21:35 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: zhang.enpei@....com.cn
Cc: horia.geanta@....com, pankaj.gupta@....com, gaurav.jain@....com,
	davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, christophe.jaillet@...adoo.fr
Subject: Re: [PATCH v2] crypto: caam - switch to use devm_kmemdup_array()

On Wed, Jul 23, 2025 at 10:50:27AM +0800, zhang.enpei@....com.cn wrote:
> From: Zhang Enpei <zhang.enpei@....com.cn>
> 
> Use devm_kmemdup_array() to avoid multiplication or possible overflows.
> 
> Signed-off-by: Zhang Enpei <zhang.enpei@....com.cn>
> ---
>  drivers/crypto/caam/ctrl.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
> index ce7b99019537..2250dce9c344 100644
> --- a/drivers/crypto/caam/ctrl.c
> +++ b/drivers/crypto/caam/ctrl.c
> @@ -592,9 +592,9 @@ static int init_clocks(struct device *dev, const struct caam_imx_data *data)
>         int ret;
> 
>         ctrlpriv->num_clks = data->num_clks;
> -       ctrlpriv->clks = devm_kmemdup(dev, data->clks,
> -                                     data->num_clks * sizeof(data->clks[0]),
> -                                     GFP_KERNEL);
> +       ctrlpriv->clks = devm_kmemdup_array(dev, data->clks,
> +                                           data->num_clks, sizeof(*data->clks),
> +                                           GFP_KERNEL);
>         if (!ctrlpriv->clks)
>                 return -ENOMEM;

This patch doesn't apply because it is space-damaged.  Please
resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt