linux-kernel - Re: [PATCH 1/7] clk: sunxi-ng: a523: add missing usb related clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e149bdb-8830-42a2-927b-a489b4195015@kernel.org>
Date: Sat, 16 Aug 2025 11:30:01 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: iuncuim <iuncuim@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
 Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>, Andre Przywara
 <andre.przywara@....com>, Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>,
 Philipp Zabel <p.zabel@...gutronix.de>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-phy@...ts.infradead.org,
 linux-clk@...r.kernel.org, linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH 1/7] clk: sunxi-ng: a523: add missing usb related clocks

On 16/08/2025 10:46, iuncuim wrote:
> From: Mikhail Kalashnikov <iuncuim@...il.com>
> 
> Several clocks were omitted when adding the original driver. These clocks
> are necessary for USB 3.0 to work correctly. I added these declarations
> according to the driver's BSP code.
> 
> Signed-off-by: Mikhail Kalashnikov <iuncuim@...il.com>
> ---
>  drivers/clk/sunxi-ng/ccu-sun55i-a523.c      | 32 +++++++++++++++++++++
>  drivers/clk/sunxi-ng/ccu-sun55i-a523.h      |  2 +-
>  include/dt-bindings/clock/sun55i-a523-ccu.h |  4 +++


Bindings should be a separate patch. Checkpatch should also suggest that.

Best regards,
Krzysztof