linux-kernel - Re: [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7468189-deee-449f-b7d0-fa1830ca88fc@kernel.org>
Date: Sat, 16 Aug 2025 11:31:12 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: iuncuim <iuncuim@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
 Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>, Andre Przywara
 <andre.przywara@....com>, Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>,
 Philipp Zabel <p.zabel@...gutronix.de>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-phy@...ts.infradead.org,
 linux-clk@...r.kernel.org, linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy

On 16/08/2025 10:46, iuncuim wrote:
> From: Mikhail Kalashnikov <iuncuim@...il.com>
> 
> It seems that there are actually three usb2 phys in the processor, which
> makes it incompatible with D1.
> The third phy is used together with USB3/PCIe combophy with DWC3
> controller. In the BSP code, the third PHY requires a separate glue
> driver, but it seems that it is not needed.
> According to the BSP code, the third phy does not have a reset line; the
> only reset is declared in the DWC3 node, but none of this is documented.
> Since sun4i-usb-phy driver requires a reset, I added RST_BUS_3 here.
> 
> Signed-off-by: Mikhail Kalashnikov <iuncuim@...il.com>
> ---
>  .../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 21 ++++++++++++-------
>  1 file changed, 13 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> index 6b6f2296b..e4ed4fa82 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> @@ -503,22 +503,27 @@ usb_otg: usb@...0000 {
>  		};
>  
>  		usbphy: phy@...0400 {
> -			compatible = "allwinner,sun55i-a523-usb-phy",
> -				     "allwinner,sun20i-d1-usb-phy";
> +			compatible = "allwinner,sun55i-a523-usb-phy";


That's potential break of all users. Also, having third phy (so
additional piece) is not making things incompatible.



Best regards,
Krzysztof