linux-kernel - Re: [PATCH] hwrng: nomadik: add ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKBQnVHyaSjr4uQ2@gondor.apana.org.au>
Date: Sat, 16 Aug 2025 17:34:21 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Olivia Mackall <olivia@...enic.com>,
	Cai Huoqing <cai.huoqing@...ux.dev>, Arnd Bergmann <arnd@...db.de>,
	Dragan Simic <dsimic@...jaro.org>,
	Francesco Dolcini <francesco.dolcini@...adex.com>,
	Daniel Golle <daniel@...rotopia.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Christian Marangi <ansuelsmth@...il.com>,
	Aurelien Jarno <aurelien@...el32.net>,
	Markus Mayer <mmayer@...adcom.com>,
	Lukas Bulwahn <lukas.bulwahn@...hat.com>,
	Nicolas Frattaroli <nicolas.frattaroli@...labora.com>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwrng: nomadik: add ARM_AMBA dependency

On Tue, Jul 29, 2025 at 05:28:00PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Compile-testing this driver is only possible when the AMBA bus driver is
> available in the kernel:
> 
> x86_64-linux-ld: drivers/char/hw_random/nomadik-rng.o: in function `nmk_rng_remove':
> nomadik-rng.c:(.text+0x67): undefined reference to `amba_release_regions'
> x86_64-linux-ld: drivers/char/hw_random/nomadik-rng.o: in function `nmk_rng_probe':
> nomadik-rng.c:(.text+0xee): undefined reference to `amba_request_regions'
> x86_64-linux-ld: nomadik-rng.c:(.text+0x18d): undefined reference to `amba_release_regions'
> 
> The was previously implied by the 'depends on ARCH_NOMADIK', but needs to be
> specified for the COMPILE_TEST case.
> 
> Fixes: d5e93b3374e4 ("hwrng: Kconfig - Add helper dependency on COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/char/hw_random/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt