linux-kernel - Re: [PATCH v2 11/24] media: iris: Add support for video encoder device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4dd20ac-84d8-422a-95a3-4d5c77b875a0@linaro.org>
Date: Sat, 16 Aug 2025 12:21:29 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Dikshita Agarwal <quic_dikshita@...cinc.com>,
 Vikash Garodia <quic_vgarodia@...cinc.com>,
 Abhinav Kumar <abhinav.kumar@...ux.dev>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil
 <hverkuil@...all.nl>, Stefan Schmidt <stefan.schmidt@...aro.org>,
 Vedang Nagar <quic_vnagar@...cinc.com>
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, Renjiang Han <quic_renjiang@...cinc.com>,
 Wangao Wang <quic_wangaow@...cinc.com>
Subject: Re: [PATCH v2 11/24] media: iris: Add support for video encoder
 device

On 13/08/2025 10:38, Dikshita Agarwal wrote:
> +	if (type == DECODER) {
> +		strscpy(vdev->name, "qcom-iris-decoder", sizeof(vdev->name));
> +		ret = video_register_device(vdev, VFL_TYPE_VIDEO, -1);
> +		if (ret)
> +			goto err_vdev_release;
> +		core->vdev_dec = vdev;
> +	} else if (type == ENCODER) {
> +		strscpy(vdev->name, "qcom-iris-encoder", sizeof(vdev->name));
> +		ret = video_register_device(vdev, VFL_TYPE_VIDEO, -1);
> +		if (ret)
> +			goto err_vdev_release;
> +		core->vdev_enc = vdev;
> +	} else {

A bit of duplicate reduction.

if (type == DECODER) {
	strscpy(vdev->name, "qcom-iris-decoder", sizeof(vdev->name));
	core->vdev_dec = vdev;
} else if (type == ENCODER) {
	strscpy(vdev->name, "qcom-iris-encoder", sizeof(vdev->name));
	core->vdev_enc = vdev;
} else {
	ret = -EINVAL;
	goto err_vdev_release;
}

ret = video_register_device(vdev, VFL_TYPE_VIDEO, -1);
if (ret)
	goto err_vdev_release;

once done

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>

---
bod