linux-kernel - Re: [PATCH 1/3] dt-bindings: rtc: Add Apple SMC RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <620292ee-46c7-4b9c-9047-86f8c771384a@kernel.org>
Date: Sat, 16 Aug 2025 14:46:15 +0200
From: Sven Peter <sven@...nel.org>
To: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>
Cc: Janne Grunau <j@...nau.net>, Alyssa Rosenzweig <alyssa@...enzweig.io>,
 Neal Gompa <neal@...pa.dev>, Lee Jones <lee@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Alexandre Belloni <alexandre.belloni@...tlin.com>,
 asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-rtc@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: rtc: Add Apple SMC RTC

On 14.08.25 23:19, Rob Herring wrote:
> On Wed, Aug 13, 2025 at 08:14:51AM +0200, Krzysztof Kozlowski wrote:
>> On 12/08/2025 20:25, Sven Peter wrote:
>>> +maintainers:
>>> +  - Sven Peter <sven@...nel.org>
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: apple,smc-rtc
>>> +
>>
>> No resources except nvmem? This should be folded into the parent. Don't
>> create device node to instantiate drivers.
> 
> Well, the reboot node has nvmem entries too, so probably better to keep
> this as child node.
> 
> Is there more functionality planned/needed here (for the mfd)? If so,
> please send it all at once. One child node at a time makes DT
> maintainers grumpy.

I'd very much like to avoid that!

There's one more driver (hwmon) that needs another child node and two 
more sub-devices that don't need any or expose any resources (hid for 
the power button and power/supply for batteries). I've talked to James
(who wrote hwmon) and he's going to submit the hwmon series together 
with at least rtc (and hid) so that you can see all additional bindings 
at once.


Thanks,


Sven