lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aKCY182EIzEZCV4P@shine.dominikbrodowski.net>
Date: Sat, 16 Aug 2025 16:42:31 +0200
From: Dominik Brodowski <linux@...inikbrodowski.net>
To: Bagas Sanjaya <bagasdotme@...il.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Kernel Janitors <kernel-janitors@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Yang Yingliang <yangyingliang@...wei.com>,
	Lee Jones <lee@...nel.org>, Randy Dunlap <rdunlap@...radead.org>,
	Shaomin Deng <dengshaomin@...rlc.com>,
	Jilin Yuan <yuanjilin@...rlc.com>, Mao Zhu <zhumao001@...suo.com>
Subject: Re: [PATCH] pcmcia: ds: Emphasize "really" epizeuxis

Applied to pcmcia-next.

Thanks,
	Dominik

Am Mon, Aug 11, 2025 at 09:04:37AM +0700 schrieb Bagas Sanjaya:
> pcmcia_dev_present() comment writes about small timeframe where
> the function returns NULL (racy condition), in epizeuxis device. In the
> past, it tripped contributors who misunderstood it for "really"
> duplicate ([1], [2]).
> 
> Add comma between "really" words to emphasize the epizeuxis.
> 
> Link: https://lore.kernel.org/all/YxT1As38WRZcyH0%2F@shine.dominikbrodowski.net/ [1]
> Link: https://lore.kernel.org/all/20220831083623.GA25639@isilmar-4.linta.de/ [2]
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>
> ---
>  drivers/pcmcia/ds.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c
> index da6f66f357cc10..18f4eef28dbc5d 100644
> --- a/drivers/pcmcia/ds.c
> +++ b/drivers/pcmcia/ds.c
> @@ -1308,7 +1308,7 @@ static int pcmcia_bus_early_resume(struct pcmcia_socket *skt)
>   * physically present, even if the call to this function returns
>   * non-NULL. Furthermore, the device driver most likely is unbound
>   * almost immediately, so the timeframe where pcmcia_dev_present
> - * returns NULL is probably really really small.
> + * returns NULL is probably really, really small.
>   */
>  struct pcmcia_device *pcmcia_dev_present(struct pcmcia_device *_p_dev)
>  {
> 
> base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
> -- 
> An old man doll... just what I always wanted! - Clara
> 
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ