linux-kernel - Re: [PATCH] pcmcia: omap: Add missing check for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKCY-rmXymcSNrhr@shine.dominikbrodowski.net>
Date: Sat, 16 Aug 2025 16:43:06 +0200
From: Dominik Brodowski <linux@...inikbrodowski.net>
To: Chen Ni <nichen@...as.ac.cn>
Cc: tony@...mide.com, arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pcmcia: omap: Add missing check for platform_get_resource

Am Thu, Mar 20, 2025 at 02:39:56PM +0800 schrieb Chen Ni:
> Add missing check for platform_get_resource() and return error if it fails
> to catch the error.
> 
> Fixes: d87d44f7ab35 ("ARM: omap1: move CF chipselect setup to board file")
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>

Applied to pcmcia-next, thanks.

Best,
	Dominik

> ---
>  drivers/pcmcia/omap_cf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pcmcia/omap_cf.c b/drivers/pcmcia/omap_cf.c
> index f0ccf479f36e..e0a3820acaef 100644
> --- a/drivers/pcmcia/omap_cf.c
> +++ b/drivers/pcmcia/omap_cf.c
> @@ -215,6 +215,8 @@ static int __init omap_cf_probe(struct platform_device *pdev)
>  		return -EINVAL;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res)
> +		return -EINVAL;
>  
>  	cf = kzalloc(sizeof *cf, GFP_KERNEL);
>  	if (!cf)
> -- 
> 2.25.1
> 
>