linux-kernel - Re: [PATCH net 2/2] microchip: lan865x: fix missing configuration for Rev.B0/B1 as per AN1760

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250815184019.68116359@kernel.org>
Date: Fri, 15 Aug 2025 18:40:19 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Parthiban Veerasooran <parthiban.veerasooran@...rochip.com>
Cc: <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net 2/2] microchip: lan865x: fix missing configuration
 for Rev.B0/B1 as per AN1760

On Wed, 13 Aug 2025 16:03:55 +0530 Parthiban Veerasooran wrote:
> +#define LAN865X_REG_FIXUP		0x00010077
> +#define LAN865X_FIXUP_VALUE		0x0028

Looks like the application note explains what this register is and what
is the meaning of the bits in it. Please break this up and name
properly. "FIXUP_REGISTER" and "FIXUP_VALUE" is about as useful
as naming it "REGSITER_AT_10077" and "VALUE_28" :/
-- 
pw-bot: cr