linux-kernel - Re: [PATCH v2 7/8] dt-bindings: media: Add MT8189 mediatek,vcodec-encoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0374df6e0002723b42548101d47658a8b178dea7.camel@mediatek.com>
Date: Sat, 16 Aug 2025 01:54:08 +0000
From: Kyrie Wu (吴晗) <Kyrie.Wu@...iatek.com>
To: "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	George Sun (孙林) <George.Sun@...iatek.com>,
	Tiffany Lin (林慧珊) <tiffany.lin@...iatek.com>,
	"andrzejtp2010@...il.com" <andrzejtp2010@...il.com>, "nhebert@...omium.org"
	<nhebert@...omium.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "mchehab@...nel.org" <mchehab@...nel.org>,
	"hverkuil@...all.nl" <hverkuil@...all.nl>, "nicolas.dufresne@...labora.com"
	<nicolas.dufresne@...labora.com>, Kyrie Wu (吴晗)
	<Kyrie.Wu@...iatek.com>, Yunfei Dong (董云飞)
	<Yunfei.Dong@...iatek.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	Irui Wang (王瑞) <Irui.Wang@...iatek.com>,
	"robh@...nel.org" <robh@...nel.org>, "sebastian.fricke@...labora.com"
	<sebastian.fricke@...labora.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "christophe.jaillet@...adoo.fr"
	<christophe.jaillet@...adoo.fr>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"arnd@...db.de" <arnd@...db.de>,
	Andrew-CT Chen (陳智迪)
	<Andrew-CT.Chen@...iatek.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "neil.armstrong@...aro.org"
	<neil.armstrong@...aro.org>
Subject: Re: [PATCH v2 7/8] dt-bindings: media: Add MT8189
 mediatek,vcodec-encoder

On Mon, 2025-08-11 at 10:07 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Mon, Aug 11, 2025 at 11:26:14AM +0800, Kyrie Wu wrote:
> > Add MT8189 encoder compatible string to distinguish former ICs
> > MTK's. Compared with MT8196, the maximum resolution of MT8189
> > encoder is only 4K, and the fps is only 30, which cannot reach
> > the highest parameter of MT8196: level6.2, 8K@...ps.
> > Compared with MT8188, the level can only support 5.1, which is less
> > than 5.2 of MT8188. But the maximum bitrate is 100Mbps, which is
> > twice
> > that of MT8188. And MT8189 could support NBM mode.
> > 
> > Signed-off-by: Kyrie Wu <kyrie.wu@...iatek.com>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > ---
> >  .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml      |
> > 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > index 7675391d7eb0..faee838d684e 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > @@ -25,6 +25,7 @@ properties:
> >                - mediatek,mt8192-vcodec-enc
> >                - mediatek,mt8195-vcodec-enc
> >                - mediatek,mt8196-vcodec-enc
> > +              - mediatek,mt8189-vcodec-enc
> 
> Same issue... you got these comments on your v1 of your other
> patchset,
> didn't you?
> 
> Best regards,
> Krzysztof
> 
Dear Krzysztof,

Thanks again. I might have overlooked the comments,
but I previously only sent a patch set of 8196 JPEG and
placed it at the end of properties strings.

I'll correct this in the next version.

Thank you.

Regards,
Kyrie.