linux-kernel - Re: [PATCH 1/2] clk: thead: th1520-ap: describe gate clocks with clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKERV0c7jat//279@x1>
Date: Sat, 16 Aug 2025 16:16:39 -0700
From: Drew Fustini <fustini@...nel.org>
To: Troy Mitchell <troy.mitchell@...ux.dev>
Cc: Icenowy Zheng <uwu@...nowy.me>, Guo Ren <guoren@...nel.org>,
	Fu Wei <wefu@...hat.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>,
	Michal Wilczynski <m.wilczynski@...sung.com>,
	Yao Zi <ziyao@...root.org>, Han Gao <rabenda.cn@...il.com>,
	linux-riscv@...ts.infradead.org, linux-clk@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] clk: thead: th1520-ap: describe gate clocks with
 clk_gate

On Sat, Aug 16, 2025 at 04:11:47PM +0800, Troy Mitchell wrote:
> On Thu, Aug 14, 2025 at 01:11:35AM +0800, Icenowy Zheng wrote:
> > Similar to previous situation of mux clocks, the gate clocks of
> > clk-th1520-ap drivers are also using a helper that creates a temporary
> > struct clk_hw and abandons the struct clk_hw in struct ccu_common, which
> > prevents clock gates to be clock parents.
> > 
> > Do the similar refactor of dropping struct ccu_common and directly use
> > struct clk_gate here.
> > 
> > This patch mimics the refactor done on struct ccu_mux at [1].
> > 
> > [1] https://lore.kernel.org/all/20250722080535.60027-2-ziyao@disroot.org/
> Should we remove this link to the cover-letter?
>                 - Troy

Good point. Yes, I think this would be better than a link as it is now
in master:

54edba916e29 ("clk: thead: th1520-ap: Describe mux clocks with clk_mux")

There is already v2 posted so no need for v3 just for this. I can fixup
when applying.

Thanks,
Drew