linux-kernel - Re: [PATCH 10/14] scsi: scsi_error: Add helper to handle scsi target's error command list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202508170715.5Q0ZpgmO-lkp@intel.com>
Date: Sun, 17 Aug 2025 07:19:39 +0800
From: kernel test robot <lkp@...el.com>
To: JiangJianJun <jiangjianjun3@...wei.com>,
	James.Bottomley@...senpartnership.com, martin.petersen@...cle.com,
	linux-scsi@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	hare@...e.de, bvanassche@....org, michael.christie@...cle.com,
	hch@...radead.org, haowenchao22@...il.com, john.g.garry@...cle.com,
	hewenliang4@...wei.com, yangyun50@...wei.com, wuyifeng10@...wei.com,
	wubo40@...wei.com, yangxingui@...artners.com
Subject: Re: [PATCH 10/14] scsi: scsi_error: Add helper to handle scsi
 target's error command list

Hi JiangJianJun,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jejb-scsi/for-next]
[also build test WARNING on mkp-scsi/for-next linus/master v6.17-rc1 next-20250815]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/JiangJianJun/scsi-scsi_error-Define-framework-for-LUN-target-based-error-handle/20250816-185707
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link:    https://lore.kernel.org/r/20250816112417.3581253-11-jiangjianjun3%40huawei.com
patch subject: [PATCH 10/14] scsi: scsi_error: Add helper to handle scsi target's error command list
config: sh-randconfig-002-20250817 (https://download.01.org/0day-ci/archive/20250817/202508170715.5Q0ZpgmO-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250817/202508170715.5Q0ZpgmO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508170715.5Q0ZpgmO-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/scsi/scsi_error.c:46:
   drivers/scsi/scsi_error.c: In function 'starget_eh_reset_target':
>> drivers/scsi/scsi_error.c:2671:30: warning: '%s' directive argument is null [-Wformat-overflow=]
    2671 |                              "%s: Target reset %s\n", current->comm,
         |                              ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/scsi/scsi_logging.h:51:25: note: in definition of macro 'SCSI_CHECK_LOGGING'
      51 |                         CMD;                                    \
         |                         ^~~
   drivers/scsi/scsi_error.c:2670:9: note: in expansion of macro 'SCSI_LOG_ERROR_RECOVERY'
    2670 |         SCSI_LOG_ERROR_RECOVERY(3, starget_printk(KERN_INFO, starget,
         |         ^~~~~~~~~~~~~~~~~~~~~~~
   include/scsi/scsi_device.h:478:9: note: in expansion of macro 'dev_printk'
     478 |         dev_printk(prefix, &(starget)->dev, fmt, ##a)
         |         ^~~~~~~~~~
   drivers/scsi/scsi_error.c:2670:36: note: in expansion of macro 'starget_printk'
    2670 |         SCSI_LOG_ERROR_RECOVERY(3, starget_printk(KERN_INFO, starget,
         |                                    ^~~~~~~~~~~~~~
   drivers/scsi/scsi_error.c:2671:48: note: format string is defined here
    2671 |                              "%s: Target reset %s\n", current->comm,
         |                                                ^~


vim +2671 drivers/scsi/scsi_error.c

  2648	
  2649	static int starget_eh_reset_target(struct scsi_target *starget,
  2650					    struct list_head *work_q,
  2651					    struct list_head *done_q)
  2652	{
  2653		enum scsi_disposition rtn;
  2654		struct scsi_cmnd *scmd, *next;
  2655		LIST_HEAD(check_list);
  2656	
  2657		scmd = list_first_entry(work_q, struct scsi_cmnd, eh_entry);
  2658	
  2659		SCSI_LOG_ERROR_RECOVERY(3, starget_printk(KERN_INFO, starget,
  2660				     "%s: Sending target reset\n", current->comm));
  2661	
  2662		rtn = scsi_try_target_reset(scmd);
  2663		if (rtn != SUCCESS && rtn != FAST_IO_FAIL) {
  2664			SCSI_LOG_ERROR_RECOVERY(3, starget_printk(KERN_INFO, starget,
  2665					     "%s: Target reset failed\n",
  2666					     current->comm));
  2667			return 0;
  2668		}
  2669	
  2670		SCSI_LOG_ERROR_RECOVERY(3, starget_printk(KERN_INFO, starget,
> 2671				     "%s: Target reset %s\n", current->comm,
  2672					 scsi_mlreturn_string(rtn)));
  2673	
  2674		list_for_each_entry_safe(scmd, next, work_q, eh_entry) {
  2675			if (rtn == SUCCESS)
  2676				list_move_tail(&scmd->eh_entry, &check_list);
  2677			else if (rtn == FAST_IO_FAIL)
  2678				scsi_eh_finish_cmd(scmd, done_q);
  2679		}
  2680	
  2681		return scsi_eh_test_devices(&check_list, work_q, done_q, 0);
  2682	}
  2683	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki