linux-kernel - Re: [PATCH net-next V3 4/5] devlink: Make health reporter error burst period configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <016a3fed-2f4b-4721-b92c-cf00cd5f3125@nvidia.com>
Date: Sun, 17 Aug 2025 19:08:47 +0300
From: Shahar Shitrit <shshitrit@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>, Tariq Toukan <tariqt@...dia.com>
Cc: Jiri Pirko <jiri@...dia.com>, Jiri Pirko <jiri@...nulli.us>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Donald Hunter <donald.hunter@...il.com>,
 Jonathan Corbet <corbet@....net>, Brett Creeley <brett.creeley@....com>,
 Michael Chan <michael.chan@...adcom.com>,
 Pavan Chebbi <pavan.chebbi@...adcom.com>, Cai Huoqing
 <cai.huoqing@...ux.dev>, Tony Nguyen <anthony.l.nguyen@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Sunil Goutham <sgoutham@...vell.com>, Linu Cherian <lcherian@...vell.com>,
 Geetha sowjanya <gakula@...vell.com>, Jerin Jacob <jerinj@...vell.com>,
 hariprasad <hkelam@...vell.com>, Subbaraya Sundeep <sbhatta@...vell.com>,
 Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
 Mark Bloch <mbloch@...dia.com>, Ido Schimmel <idosch@...dia.com>,
 Petr Machata <petrm@...dia.com>, Manish Chopra <manishc@...vell.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
 linux-rdma@...r.kernel.org, Gal Pressman <gal@...dia.com>,
 Dragos Tatulea <dtatulea@...dia.com>
Subject: Re: [PATCH net-next V3 4/5] devlink: Make health reporter error burst
 period configurable

On 15/08/2025 22:26, Jakub Kicinski wrote:
> On Wed, 13 Aug 2025 21:55:48 +0300 Tariq Toukan wrote:
>> diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml
>> index bb87111d5e16..0e81640dd3b2 100644
>> --- a/Documentation/netlink/specs/devlink.yaml
>> +++ b/Documentation/netlink/specs/devlink.yaml
>> @@ -853,6 +853,9 @@ attribute-sets:
>>          type: nest
>>          multi-attr: true
>>          nested-attributes: dl-rate-tc-bws
>> +      -
>> +        name: health-reporter-error-burst-period
> 
> the "graceful-period" does not have the word "error"
> in it. Why is it necessary to include it in this parameter?
> What else would be bursting in an error reporter if not errors?

I see. Would you suggest renaming it to "burst period" through the
entire series?
for example in devlink.h:
default_error_burst_period --> default_burst_period
> 
>> +        type: u64
> 
> could you add a doc: here?
> 
>>    -
>>      name: dl-dev-stats
>>      subset-of: devlink
> 
>> +	DEVLINK_ATTR_HEALTH_REPORTER_ERR_BURST_PERIOD,	/* u64 */
> 
> The _ERR here won't work if you used _ERROR in YAML. 
> The naming in the YAML spec must match the C naming exactly.