linux-kernel - Re: [PATCH net-next] xfrm: xfrm_user: use strscpy() for alg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABKbRoLQQw_E0zFg5nxXwncf1EYA931_L7DUEc4TWvPjBc4j0Q@mail.gmail.com>
Date: Sun, 17 Aug 2025 21:17:35 +0200
From: Miguel García Román <miguelgarciaroman8@...il.com>
To: Steffen Klassert <steffen.klassert@...unet.com>
Cc: herbert@...dor.apana.org.au, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org
Subject: Re: [PATCH net-next] xfrm: xfrm_user: use strscpy() for alg_name

El dom, 17 ago 2025 a las 16:48, Steffen Klassert
(<steffen.klassert@...unet.com>) escribió:
>
> On Thu, Aug 14, 2025 at 09:32:17PM +0200, Miguel García wrote:
> > Replace the strcpy() calls that copy the canonical algorithm name into
> > alg_name with strscpy() to avoid potential overflows and guarantee NULL
> > termination.
> >
> > Destination is alg_name in xfrm_algo/xfrm_algo_auth/xfrm_algo_aead
> > (size CRYPTO_MAX_ALG_NAME).
> >
> > Tested in QEMU (BusyBox/Alpine rootfs):
> >  - Added ESP AEAD (rfc4106(gcm(aes))) and classic ESP (sha256 + cbc(aes))
> >  - Verified canonical names via ip -d xfrm state
> >  - Checked IPComp negative (unknown algo) and deflate path
> >
> > Signed-off-by: Miguel García <miguelgarciaroman8@...il.com>
>
> Patch applied, thanks!
Perfect, thanks!